Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update H5P to latest #12993

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 9, 2025

Summary

  • Tweaks our H5P vendoring script to be less restrictive in terms of the files it unzips
  • Updates H5P to the latest from upstream

References

Diff h5p/h5p-php-library@eeefc12...fb5100a

Reviewer guidance

This should be checked against our comprehensive H5P testing channel - but can start with those we have in the QA channel.

@pcenov
Copy link
Member

pcenov commented Jan 10, 2025

Hi @rtibbles - unfortunately none of the H5P resources from the QA channel can be started. Getting the following error in the console:

627-aa1ed38517f4010eb1dc.bundle.js:1 Uncaught URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:4162
    at Function.from (<anonymous>)
    at S (627-aa1ed38517f4010eb1dc.bundle.js:1:3679)
    at e.value (627-aa1ed38517f4010eb1dc.bundle.js:1:4591)
    at t.value (627-aa1ed38517f4010eb1dc.bundle.js:1:11771)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:13462
    at Array.map (<anonymous>)
    at 627-aa1ed38517f4010eb1dc.bundle.js:1:12492
    at 451-381dff277bf2e6336c0e.bundle.js:1:7339
2025-01-10_14-44-25.mp4

Logs: logs.zip

@radinamatic
Copy link
Member

Same here (Chrome and Firefox on Ubuntu 20.04)

2025-01-10_15-59-45

@rtibbles
Copy link
Member Author

Bah, thanks, will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants