Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of language buttons in setup flow #13024

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

malviya-rajveer
Copy link

@malviya-rajveer malviya-rajveer commented Jan 22, 2025

Summary

before alignment of languages

Screenshot from 2025-01-23 22-32-42

After alignment of languages

Screenshot from 2025-01-24 13-07-46

@MisRob
Copy link
Member

MisRob commented Jan 23, 2025

Hi @malviya-rajveer, thanks!

Would you please post before/after screenshot? Also for next time, it's best to keep the pull request description template and fill it in as it guides you to provide information that's needed.

Also, before working on an issue, next time I'd suggest you ask for an assignment first. See more in the contributing guidelines.

@malviya-rajveer
Copy link
Author

Hello @MisRob, thank you for reviewing my pull request! I really appreciate your time and feedback. I apologize for not including the before/after screenshots; I understand how important they are for clarity. I'll be sure to follow the pull request description template more closely in the future.

I also appreciate your suggestion regarding assignment requests before working on issues. I’ll make sure to refer to the contributing guidelines next time. Thank you for your guidance!

@MisRob
Copy link
Member

MisRob commented Jan 24, 2025

No worries and thank you @malviya-rajveer

@MisRob MisRob requested review from MisRob and AllanOXDi January 24, 2025 04:12
@MisRob MisRob added the TODO: needs review Waiting for review label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alignment of language buttons in setup flow
2 participants