Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react axios example #39

Merged
merged 5 commits into from
Oct 8, 2020

Conversation

fernandoamz
Copy link
Contributor

@fernandoamz fernandoamz commented Oct 6, 2020

Add react axios example

This is a part of the issue #32

Screen Shot 2020-10-07 at 12 17 01 PM

@lelouchB lelouchB linked an issue Oct 7, 2020 that may be closed by this pull request
6 tasks
@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

@fernandoamz Great Work,
I was thinking since this example is quite similar to react example, instead of separate page maybe we can add a TAB in the react example for this.
First one being React and the other being React+Axios.

Resource : https://v2.docusaurus.io/docs/markdown-features#tabs
Something familiar to this
image

Thanks

@fernandoamz
Copy link
Contributor Author

fernandoamz commented Oct 7, 2020

Yeah @lelouchB, I will add as a tab form. I will update as soon as possible.

@fernandoamz
Copy link
Contributor Author

@lelouchB, I added the example as tab, but I am getting conflicts with your original react.md I cannot resolve the conflicts the button is locked. but, take a look an tell me what think about the change.

@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

Hey @fernandoamz
There has been some updates in the repo, also in react.md file.

You need to update your branch to resolve these conflicts.

@fernandoamz
Copy link
Contributor Author

@lelouchB, I could fix the conflicts

@fernandoamz
Copy link
Contributor Author

@lelouchB, If the changes are accepted. May you add the hacktoberfest-accepted tag?

Screen Shot 2020-10-07 at 1 12 20 PM

@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

@lelouchB, If the changes are accepted. May you add the hacktoberfest-accepted tag?

Screen Shot 2020-10-07 at 1 12 20 PM

I have approved it and will merge it soon so it should be okay.
But I will still add that label.

Thanks

@lelouchB lelouchB merged commit 8ef1928 into lelouchB:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Examples to the Documentation
2 participants