Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Identifiers to Authorization & Order structs #7961

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

jprenken
Copy link
Contributor

@jprenken jprenken commented Jan 21, 2025

Add identifier fields, which will soon replace the dnsName fields, to:

  • corepb.Authorization
  • corepb.Order
  • rapb.NewOrderRequest
  • sapb.CountFQDNSetsRequest
  • sapb.CountInvalidAuthorizationsRequest
  • sapb.FQDNSetExistsRequest
  • sapb.GetAuthorizationsRequest
  • sapb.GetOrderForNamesRequest
  • sapb.GetValidAuthorizationsRequest
  • sapb.NewOrderRequest

Populate these identifier fields in every function that creates instances of these structs.

Use these identifier fields instead of dnsName fields (at least preferentially) in every function that uses these structs. When crossing component boundaries, don't assume they'll be present, for deployability's sake.

Deployability note: Mismatched cert-checker and sa versions will be incompatible because of a type change in the arguments to sa.SelectAuthzsMatchingIssuance.

Part of #7311

Add `identifier` fields, which will soon replace the `dnsName` fields, to:
- `corepb.Authorization`
- `corepb.Order`
- `rapb.NewOrderRequest`
- `sapb.CountFQDNSetsRequest`
- `sapb.CountInvalidAuthorizationsRequest`
- `sapb.FQDNSetExistsRequest`
- `sapb.GetAuthorizationsRequest`
- `sapb.GetOrderForNamesRequest`
- `sapb.GetValidAuthorizationsRequest`
- `sapb.NewOrderRequest`

Populate these `identifier` fields in every function that creates instances of these structs.

Preferentially use these `identifier` fields in every function that uses these structs - but when crossing component boundaries, don't assume they'll be present, for deployability's sake.

Part of #7311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant