ra: Gate OCSP Must-Staple issuance on account-based allow list #7976
+171
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
previously approved these changes
Jan 24, 2025
aarongable
requested changes
Jan 24, 2025
beautifulentropy
force-pushed
the
must-staple-allowlist
branch
from
e136bdc to
753a2ef
Compare
beautifulentropy
changed the title
jprenken
approved these changes
Jan 24, 2025
aarongable
approved these changes
Jan 25, 2025
Comment on lines
+959
to
+960
| if ra.mustStapleAllowList != nil { | ||
| if issuance.ContainsMustStaple(csr.Extensions) { |
There was a problem hiding this comment.
nit: I'd collapse these onto a single line, to prevent too much nesting, and to prevent readers from being confused about which of these three consecutive if clauses the else below corresponds to
Suggested change
| if ra.mustStapleAllowList != nil { | |
| if issuance.ContainsMustStaple(csr.Extensions) { | |
| if ra.mustStapleAllowList != nil && issuance.ContainsMustStaple(csr.Extensions) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in the RA for an allow list of accounts permitted to request certificates containing the OCSP Must-Staple extension. If no allow list is configured, all accounts are permitted. When a list is provided, Finalize requests with Must-Staple are rejected unless the account is on the list, and metrics are updated to track allowed and denied requests.
Fixes #7914
Warning
Do not merge until #7959 has been merged.