using boolean instead of integer

libp2p · Dec 7, 2024 · 5a0716d · 5a0716d
1 parent f02d038
commit 5a0716d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/libp2p/pubsub/pubsub.py b/libp2p/pubsub/pubsub.py
@@ -116,7 +116,7 @@ class Pubsub(Service, IPubsub):
     peer_receive_channel: trio.MemoryReceiveChannel[ID]
     dead_peer_receive_channel: trio.MemoryReceiveChannel[ID]
 
-    seen_messages: LRU[bytes, int]
+    seen_messages: LRU[bytes, bool]
 
     subscribed_topics_send: dict[str, trio.MemorySendChannel[rpc_pb2.Message]]
     subscribed_topics_receive: dict[str, TrioSubscriptionAPI]
@@ -670,9 +670,7 @@ def _is_msg_seen(self, msg: rpc_pb2.Message) -> bool:
 
     def _mark_msg_seen(self, msg: rpc_pb2.Message) -> None:
         msg_id = self._msg_id_constructor(msg)
-        # FIXME: Mapping `msg_id` to `1` is quite awkward. Should investigate if there
-        # is a more appropriate way.
-        self.seen_messages[msg_id] = 1
+        self.seen_messages[msg_id] = True
 
     def _is_subscribed_to_msg(self, msg: rpc_pb2.Message) -> bool:
         return any(topic in self.topic_ids for topic in msg.topicIDs)