Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't add channel to group if more than ~10 groups #6175

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: can't add channel to group if more than ~10 groups #6175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ dependencies {
implementation(libs.kotlinx.serialization)
implementation(libs.kotlinx.datetime)
implementation(libs.kotlinx.serialization.retrofit)
testImplementation(libs.testng)

/* Cronet and Coil */
coreLibraryDesugaring(libs.desugaring)
Expand All @@ -144,4 +143,7 @@ dependencies {

/* AndroidX Paging */
implementation(libs.androidx.paging)

/* Testing */
testImplementation(libs.testng)
}
3 changes: 2 additions & 1 deletion app/src/main/res/layout/add_channel_to_group_row.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:padding="12dp">
android:paddingHorizontal="12dp"
android:paddingVertical="3dp">

<CheckBox
android:id="@+id/group_checkbox"
Expand Down
6 changes: 4 additions & 2 deletions ...res/layout/add_channel_to_group_sheet.xml → ...es/layout/dialog_add_channel_to_group.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:orientation="vertical">

<!-- Drag handle for accessibility -->
Expand Down Expand Up @@ -47,7 +47,8 @@
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/groupsRV"
android:layout_width="match_parent"
android:layout_height="wrap_content" />
android:layout_height="0dp"
android:layout_weight="1" />

<LinearLayout
android:layout_width="wrap_content"
Expand All @@ -57,6 +58,7 @@

<com.google.android.material.button.MaterialButton
android:id="@+id/cancel"
style="@style/Widget.Material3.Button.OutlinedButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/cancel" />
Expand Down
Loading