Add initial service building blocks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
elias/2024-07-basic-hyper-setup
branch
from
6197a44 to
e48c89f
Compare
jkczyz
reviewed
Jul 19, 2024
server/src/main.rs
Outdated
| println!( | ||
| "CHANNEL_PENDING: {} from counterparty {}", | ||
| channel_id, counterparty_node_id | ||
| ); |
There was a problem hiding this comment.
Fixed.
I think we'll have to drop all the printlns soon anyways in favor of some better logging. Possibly a split logger that logs to stdout and to file?
| Ok(request) => match handler(node, request) { | ||
| Ok(response) => Ok(Response::builder() | ||
| .body(Full::new(Bytes::from(response.encode_to_vec()))) | ||
| // unwrap safety: body only errors when previous chained calls failed. |
There was a problem hiding this comment.
Do we plan on doing this on every unwrap? Should we do so throughout this PR if so?
There was a problem hiding this comment.
Yes I think so. Now got rid of the unwraps when building node/runtime and added another comment.
tnull
force-pushed
the
elias/2024-07-basic-hyper-setup
branch
from
7e84e34 to
7fc39ea
Compare
Squashed without further changes. |
jkczyz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the additional daemon/service building blocks.