lxa_iobus: move the project from setup.py to pyproject.toml #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmithChart
requested changes
Mar 13, 2024
This was referenced Mar 14, 2024
hnez
force-pushed
the
pyproject-toml
branch
4 times, most recently
from
99f9784 to
f8ead7a
Compare
|
#36 has been merged. And there are conflicts. Please rebase. |
In some circumstances the pip command and python3 -m pip do not point to the same piece of software. If this is the case, then python3 -m pip is always the correct one to use, so play defensively and do the same. Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
Signed-off-by: Leonard Göhrs <[email protected]>
The pyproject.toml format is the new and modern way to package python projects. We still use setuptools under the hood to do the packaging, but configure it in the pyproject.toml. This change also moves the executable scripts from the bin folder, where they were e.g. not caught by ruff by default, into the python project folder itself. Signed-off-by: Leonard Göhrs <[email protected]>
This is mostly to check that the respective make target stil works, but maybe the generated wheels can also come in handy. Signed-off-by: Leonard Göhrs <[email protected]>
SmithChart
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pyproject.toml format is the new and modern way to package python projects. We still use setuptools under the hood to do the packaging, but configure it in the pyproject.toml.
This change also moves the executable scripts from the bin folder, where they were e.g. not caught by flake8 and black by default, into the python project folder itself.
TODO before merging:
make qaandmake sdistmake targets. Find out how to bring them back (if needed).