feat(fastapi): refactored integration with CLI support #352
Conversation
There was a problem hiding this comment.
why are we re exporting these in fastapi? I don't think there is much convenience in doing
from advanced_alchemy.fastapi import *over the normalfrom advanced_alchemy import *
It's for convenience so you don't need to import from several places with AA. It's done like this for Litestar and Flask as well.
There was a problem hiding this comment.
if you are using skip, you can probably move the fixture to a module level scope and remove decorating individual tests
pytestmark = pytest.mark.skipif( condition=sys.version_info < (3, 8), reason="Certain versions of Starlette and FastAPI are stated to still support 3.8, but there are documented incompatibilities on various versions that have not been yanked. Skipping on 3.8 for now until this is resolved.", )
It's probably important for me to point out that these are all of the existing test cases for starlette, not any that i've written yet.
github-actions
bot
added
area/dependencies
area/example-apps
and removed
size: small
labels
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/352 |
Refactored the Starlette and FastAPI integration to support multiple configurations and sessions. Additionally, FastAPI will now have the database commands automatically registered with the FastAPI CLI.