Inspect non-utf8 binaries in Kino.DataTable (#362)

lib/kino/data_table.ex

@@ -253,6 +253,11 @@ defmodule Kino.DataTable do
     end
   end
 
+  defp value_to_string(value) when is_binary(value) do
+    inspect_opts = Inspect.Opts.new([])
+    if String.printable?(value, inspect_opts.limit), do: value, else: inspect(value)
+  end
+
   defp value_to_string(value) do
     if mod = String.Chars.impl_for(value), do: mod.to_string(value), else: inspect(value)
   end

test/kino/data_table_test.exs

@@ -121,6 +121,21 @@ defmodule Kino.DataTableTest do
            } = data
   end
 
+  test "supports non-utf8 binary values" do
+    entries = [
+      binaries: [<<110, 120>>, <<200, 210>>]
+    ]
+
+    kino = Kino.DataTable.new(entries)
+    data = connect(kino)
+
+    assert %{
+             content: %{
+               data: [["nx"], ["<<200, 210>>"]]
+             }
+           } = data
+  end
+
   test "sends only relevant fields if user-specified keys are given" do
     kino = Kino.DataTable.new(@people_entries, keys: [:id])
     data = connect(kino)