Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list cell bugs - text when clicked and appropriate list icon #376

Merged
1 commit merged into from
Jan 3, 2024

Conversation

lkarthee
Copy link
Contributor

@lkarthee lkarthee commented Jan 3, 2024

When a list cell is clicked - it behaves weird, it appends list into a single word.

list_cell_click_bug.mov

After fix

image

Also the list column was using an GridColumnIcon.HeaderNumber icon when GridColumnIcon.HeaderArray icon is more appropriate.

@lkarthee
Copy link
Contributor Author

lkarthee commented Jan 3, 2024

I have done an npm install --force as normal install was failing due to incompatible react dependency. There after did a npm run build and tested the cell. Hopefully I have not missed anything.

@lkarthee lkarthee changed the title Fix list cell bugs - click and appropriate list icon Fix list cell bugs - text when clicked and appropriate list icon Jan 3, 2024
@ghost
Copy link

ghost commented Jan 3, 2024

Thanks!

@ghost ghost merged commit 405f17a into livebook-dev:main Jan 3, 2024
1 check passed
@lkarthee lkarthee deleted the list_bug_fix branch January 4, 2024 01:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant