feat!: rename and surface sraRunAccession #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anything blocking here? |
|
The metadata docs on the website are generated, also the template file is generated, so these should be fine too. Not sure about this: https://github.com/pathoplexus/pathoplexus/blob/main/monorepo/website/public/metadata_descriptions.csv @anna-parker ? |
fhennig
force-pushed
the
rename-srarunacc
branch
from
d4e347c to
bed73b3
Compare
anna-parker
approved these changes
Jan 20, 2025
fhennig
changed the title
|
yes good point! I've updated the title and description accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: value.yaml needs to be updated (see changed files).
resolves pathoplexus/pathoplexus#331
preview URL: http://rename-srarunacc.loculus.org
Summary
Screenshot
n/a
PR Checklist