-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pipeline version per Organism #3534
base: main
Are you sure you want to change the base?
Conversation
Wow, the pipeline version in the backend is not per organism? But in the |
What do you mean? The pipeline version is internal, so it doesn't appear in the values.yaml if I'm not mistaken. |
The pipeline version also occurs in the Values.yaml because it's also used to deploy the pipelines. |
loculus/kubernetes/loculus/values.yaml Lines 1148 to 1150 in 9aa28ab
This is the pipeline version, isn't it? |
Currently for the backend (/in the database) there is a single "latest pipeline version". So if you make a new pipeline version for one organism in the values yaml you have to do so for all organisms. This issue is (intended to be) about addressing that. |
Note to self: The table now starts out empty, somehow it needs to be filled. (I don't think there is a way around the table starting empty now? Because we don't know which organisms there are) |
170d08b
to
b6997b9
Compare
Update: I found a way to initialize the table on backend-startup. Now I marked some places in the schema that still need to be adjusted, that currently lead to: "ERROR: more than one row returned by a subquery used as an expression" |
From all the places I had to touch, I think the general handling of this table isn't the best unfortunately. It is different to all the other tables because it starts out with data, and all the others don't. |
resolves #1728
preview URL:
Summary
Screenshot
PR Checklist