Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pipeline version per Organism #3534

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jan 16, 2025

resolves #1728

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig fhennig self-assigned this Jan 16, 2025
@fengelniederhammer
Copy link
Contributor

Wow, the pipeline version in the backend is not per organism? But in the values.yml it's per organism, isn't it?

@fhennig
Copy link
Contributor Author

fhennig commented Jan 16, 2025

What do you mean? The pipeline version is internal, so it doesn't appear in the values.yaml if I'm not mistaken.

@chaoran-chen
Copy link
Member

The pipeline version also occurs in the Values.yaml because it's also used to deploy the pipelines.

@fengelniederhammer
Copy link
Contributor

preprocessing:
- &preprocessing
version: 1

This is the pipeline version, isn't it?

@theosanderson
Copy link
Member

theosanderson commented Jan 16, 2025

Currently for the backend (/in the database) there is a single "latest pipeline version". So if you make a new pipeline version for one organism in the values yaml you have to do so for all organisms. This issue is (intended to be) about addressing that.

@fhennig
Copy link
Contributor Author

fhennig commented Jan 23, 2025

Note to self: The table now starts out empty, somehow it needs to be filled. (I don't think there is a way around the table starting empty now? Because we don't know which organisms there are)

@fhennig fhennig force-pushed the pipeline-v-per-organism branch from 170d08b to b6997b9 Compare January 23, 2025 11:54
@fhennig
Copy link
Contributor Author

fhennig commented Jan 23, 2025

Update: I found a way to initialize the table on backend-startup.

Now I marked some places in the schema that still need to be adjusted, that currently lead to: "ERROR: more than one row returned by a subquery used as an expression"

@fhennig fhennig added the preview Triggers a deployment to argocd label Jan 23, 2025
@fhennig
Copy link
Contributor Author

fhennig commented Jan 23, 2025

From all the places I had to touch, I think the general handling of this table isn't the best unfortunately. It is different to all the other tables because it starts out with data, and all the others don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd update_db_schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pipeline version scoped at organism level rather than global
5 participants