-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): improve docs #3564
base: main
Are you sure you want to change the base?
Conversation
@@ -300,7 +301,7 @@ const InnerDataUploadForm = ({ | |||
<div className='sm:col-span-4 px-8'> | |||
{dataUseTermsType === restrictedDataUseTermsOption && ( | |||
<p className='block text-sm'> | |||
Your data will be available on Pathoplexus, under the restricted use terms until{' '} | |||
Your data will be available on Pathoplexus, under the restricted use terms, until{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change doesn't make sense to me. Your change to me implies the data will only be available on Pathoplexus until date X. Whereas it will be available in perpetuity, under the restricted terms until date X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better? Bit more explicit with "also" etc.
Until the end of the restricted period, your data will be shared on Pathoplexus with restricted use terms.
Afterwards, the use terms change to open and the data will also be released on the INSDC.
(My take is still that the existing behaviour is better re this Excel thing, but it really doesn't matter - happy to go with this) thanks for making the PR |
I don't have a strong opinion. I'm happy with the current behavior as well as with changing the text as suggested in this PR. |
@@ -243,7 +243,8 @@ const InnerDataUploadForm = ({ | |||
|
|||
<p className='text-gray-400 text-xs mt-3'> | |||
Files can optionally be compressed, with the appropriate extension (<i>.zst</i>, <i>.gz</i>,{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files can optionally be compressed, with the appropriate extension (<i>.zst</i>, <i>.gz</i>,{' '} | |
Files can optionally be compressed using <i>.zst</i>, or <i>.gz<xz>; the FASTA file also with <i>.zip</i> or <i>.xz</i> formats.{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zip also works for metadata files.
@@ -243,7 +243,8 @@ const InnerDataUploadForm = ({ | |||
|
|||
<p className='text-gray-400 text-xs mt-3'> | |||
Files can optionally be compressed, with the appropriate extension (<i>.zst</i>, <i>.gz</i>,{' '} | |||
<i>.zip</i>, <i>.xz</i>). For more information please refer to the{' '} | |||
<i>.zip</i>), <i>.xz</i> is also supported specifically for FASTA files. For more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<i>.zip</i>), <i>.xz</i> is also supported specifically for FASTA files. For more | |
For more{' '} |
partially resolves #3556
resolves #3555, resolves #3562
preview URL: https://typos.loculus.org/
Summary
Screenshot
PR Checklist