Skip to content

Commit

Permalink
Merge pull request #30 from loft-sh/fix/aws_permission_hardening
Browse files Browse the repository at this point in the history
fix(security): make stricter rules for AWS instance profile
  • Loading branch information
89luca89 authored May 7, 2024
2 parents 06d6bfd + 963d24e commit 0c18812
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/aws/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ func GetAMIRootDevice(ctx context.Context, cfg aws.Config, diskImage string) (st
},
}
result, err := svc.DescribeImages(ctx, input)

if err != nil {
return "", err
}
Expand Down Expand Up @@ -295,10 +294,7 @@ func CreateDevpodInstanceProfile(ctx context.Context, provider *AwsProvider) (st
"Sid": "VisualEditor0",
"Effect": "Allow",
"Action": [
"ec2:DescribeInstances",
"ec2:StopInstances",
"ec2:DescribeInstanceStatus",
"ec2:DescribeInstanceConnectEndpoints"
],
"Resource": "*"
}
Expand Down

0 comments on commit 0c18812

Please sign in to comment.