Update scalablyTypedImportTask to also check for IVY_HOME #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the Task to also look for IVY_HOME if the user has specified it. If not, it still defaults to ~/.ivy2. It still looks for any Java declaration flags `-Divy.home=<...>` if passed in first.
|
@lolgab -- this was following your suggestion in the other PR that I closed previously. Any chance this could be merged? |
|
Since I'm new to javaland, is the preferred option not to use environment variables and directly set properties to the JVM like with -Divy.home? If so, I can close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Task to also look for IVY_HOME if the user has specified it. If not, it still defaults to
~/.ivy2. It still looks for any Java declaration flags-Divy.home=<...>if passed in first.This was first opened by #35 and adds the suggestion for making this change additive rather than replacing the original sys.props check. Deleted the other one, because I was using github.com to make the edits, rather than on my machine.