(e2e): fix expressionStepConfig test failure

lordrip · Jan 20, 2025 · e6db8ab · e6db8ab
1 parent 3549ea5
commit e6db8ab
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/ui-tests/cypress/e2e/designer/specialStepConfiguration/expressionStepConfig.cy.ts b/packages/ui-tests/cypress/e2e/designer/specialStepConfiguration/expressionStepConfig.cy.ts
@@ -25,7 +25,7 @@ describe('Tests for sidebar expression configuration', () => {
     cy.uploadFixture('flows/camelRoute/basic.yaml');
     cy.openDesignPage();
 
-    cy.openStepConfigurationTab('setHeader', 0);
+    cy.openStepConfigurationTabByPath('custom-node__route.from.steps.0.setHeader');
     cy.selectFormTab('All');
     cy.selectExpression('JQ');
     cy.interactWithConfigInputObject('expression', '.id');
@@ -41,22 +41,22 @@ describe('Tests for sidebar expression configuration', () => {
 
     cy.checkNodeExist('setHeader', 2);
 
-    cy.openStepConfigurationTab('setHeader', 1);
+    cy.openStepConfigurationTabByPath('custom-node__route.from.steps.1.setHeader');
     cy.selectFormTab('All');
     cy.selectExpression('JQ');
     cy.interactWithConfigInputObject('expression', '.name');
     cy.addExpressionResultType('java.lang.String');
     cy.interactWithConfigInputObject('trim');
 
-    cy.openStepConfigurationTab('setHeader', 0);
+    cy.openStepConfigurationTabByPath('custom-node__route.from.steps.0.setHeader');
 
     // Check the configured fields didn't disappear from the first node
     cy.checkConfigCheckboxObject('trim', true);
     cy.checkExpressionResultType('java.lang.String');
     cy.checkConfigInputObject('expression', '.id');
 
     // Check the configured fields didn't disappear from the second node
-    cy.openStepConfigurationTab('setHeader', 0);
+    cy.openStepConfigurationTabByPath('custom-node__route.from.steps.1.setHeader');
     cy.checkConfigCheckboxObject('trim', true);
     cy.addExpressionResultType('java.lang.String');
     cy.checkConfigInputObject('expression', '.name');

diff --git a/packages/ui-tests/cypress/support/cypress.d.ts b/packages/ui-tests/cypress/support/cypress.d.ts
@@ -46,6 +46,7 @@ declare global {
       // design
       openGroupConfigurationTab(step: string, stepIndex?: number): Chainable<JQuery<Element>>;
       openStepConfigurationTab(step: string, stepIndex?: number): Chainable<JQuery<Element>>;
+      openStepConfigurationTabByPath(path: string): Chainable<JQuery<Element>>;
       toggleExpandGroup(groupName: string): Chainable<JQuery<Element>>;
       fitToScreen(): Chainable<JQuery<Element>>;
       closeStepConfigurationTab(): Chainable<JQuery<Element>>;

diff --git a/packages/ui-tests/cypress/support/next-commands/design.ts b/packages/ui-tests/cypress/support/next-commands/design.ts
@@ -7,6 +7,10 @@ Cypress.Commands.add('openStepConfigurationTab', (step: string, stepIndex?: numb
   cy.get(`g[data-nodelabel^="${step}"]`).eq(stepIndex).click({ force: true });
 });
 
+Cypress.Commands.add('openStepConfigurationTabByPath', (path: string) => {
+  cy.get(`g[data-testid="${path}"]`).click({ force: true });
+});
+
 Cypress.Commands.add('openGroupConfigurationTab', (group: string, groupIndex?: number) => {
   groupIndex = groupIndex ?? 0;
   cy.get(`g[data-grouplabel^="${group}"]`).eq(groupIndex).click({ force: true });