Implemented Material3 SearchBar feature in FoodExpirationDates App #284

anuragkanojiya1 · 2025-01-03T18:34:20Z

Related Issue

Closes #232

Description

Implemented Material3 SearchBar

This PR introduces a search functionality that allows users to easily search for items by name. The search bar is conveniently located at the top of the main screen, ensuring a seamless user experience.

Type of change

This new search feature enhances user experience by enabling quick access to desired items in FoodExpirationDates app's main screen.

Screen_recording_20250103_234153.mp4

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation

lorenzovngl · 2025-01-06T12:10:05Z

Hello @anuragkanojiya1, great job so far. Thank you for your efforts!

It seems your branch is currently 50 commits behind, which is a significant number and may miss important updates from the main branch. To bring it up to date, please rebase your branch by following these steps:

Steps to Rebase `search-feature`

Before starting, it's recommended to manually create a backup copy of your work to avoid losing progress in case of issues.

Switch to your search-feature branch:
```
git checkout search-feature
```
Fetch the latest changes from the remote repository:
```
git fetch origin
```
Rebase your branch onto the main branch:
```
git rebase origin/main
```
This will apply your commits from search-feature on top of the latest commits in the main branch.
Force push your rebased branch to the remote repository:
```
git push --force
```

I think the process will be straightforward. However, let me know if you encounter any issues or need further assistance.

lorenzovngl · 2025-01-08T20:35:05Z

I rebased the branch. Here's what I did:

Reset the branch to the state it was when you opened the PR. Hard reset, I was not interested in keeping duplicate commits.
Go to your fork on GitHub and synced the main branch using the button Sync fork. Not feature-branch, because I would lose your commit.
Return to Android Studio to fetch the latest changes.
Update local main with the latest changes.
Rebase search-feature onto main.
Finally, git push --force.

Please wait for my review in next days 😊

lorenzovngl · 2025-01-11T11:59:33Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/MyScaffold.kt

@@ -57,13 +62,15 @@ fun MyScaffold(
    navController: NavHostController,
    navDestination: String? = null,
    showSnackbar: MutableState<Boolean>,
-    content: @Composable () -> Unit
+    searchQuery : MutableState<String>,


Whenever possible, if you introduce a new parameter, add a default. This prevent you from having to change all calls of the function. Think about the situation in which a function is called 100 times.

Suggested change

searchQuery : MutableState<String>,

searchQuery : MutableState<String> = mutableStateOf(""),

lorenzovngl · 2025-01-11T12:01:17Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/MyScaffold.kt

+                showSnackbar = showSnackbar,
+                searchQuery = mutableStateOf("")


Change no longer necessary after introducing a default.

Suggested change

showSnackbar = showSnackbar,

searchQuery = mutableStateOf("")

showSnackbar = showSnackbar

lorenzovngl · 2025-01-11T12:01:59Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/MyScaffold.kt

+                    navController = rememberNavController(),
+                    searchQuery = mutableStateOf("")


Change no longer necessary after introducing a default.

Suggested change

navController = rememberNavController(),

searchQuery = mutableStateOf("")

navController = rememberNavController()

lorenzovngl · 2025-01-11T12:02:59Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/screen/InfoScreen.kt

@@ -38,7 +38,7 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
-import com.lorenzovainigli.foodexpirationdates.BuildConfig
+import com.google.android.datatransport.BuildConfig


Wrong, please revert this.

lorenzovngl · 2025-01-11T12:04:29Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/screen/MainScreen.kt

@@ -45,7 +47,8 @@ import kotlin.math.min
 fun MainScreen(
    activity: MainActivity? = null,
    navController: NavHostController,
-    showSnackbar: MutableState<Boolean>? = null
+    showSnackbar: MutableState<Boolean>? = null,
+    searchQuery: MutableState<String>


Same consideration as in MyScaffold: add a default value.

Suggested change

searchQuery: MutableState<String>

searchQuery: MutableState<String> = mutableStateOf("")

lorenzovngl · 2025-01-11T12:11:14Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/preview/PlayStoreScreenshot.kt

@@ -1,5 +1,6 @@
 package com.lorenzovainigli.foodexpirationdates.view.preview

+import android.annotation.SuppressLint


To be removed

lorenzovngl · 2025-01-11T12:11:21Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/preview/PlayStoreScreenshot.kt

@@ -74,6 +75,7 @@ fun PlayStoreScreenshot(
    }
 }

+@SuppressLint("UnrememberedMutableState")


To be removed

lorenzovngl · 2025-01-11T12:11:44Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/preview/PlayStoreScreenshot.kt

@@ -86,11 +88,12 @@ fun PlayStoreScreenshotPreview() {
            val showSnackbar = remember {
                mutableStateOf(false)
            }
-            MyScaffold(navController = navController, showSnackbar = showSnackbar) {
+            MyScaffold(navController = navController, showSnackbar = showSnackbar, searchQuery = mutableStateOf("")) {


Not necessary, please revert this change.

lorenzovngl · 2025-01-11T12:11:52Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/preview/PlayStoreScreenshot.kt

+                    startDestination = Screen.AboutScreen.route,
+                    searchQuery = mutableStateOf("")


Not necessary, please revert this change.

lorenzovngl · 2025-01-11T12:14:15Z

app/src/main/java/com/lorenzovainigli/foodexpirationdates/view/composable/MainScreenMenu.kt

+
+
+//    TopAppBar(
+//        title = {
+//            BasicTextField(
+//                value = searchQuery,
+//                onValueChange = { searchQuery = it },
+//                textStyle = TextStyle(color = Color.White, fontSize = 18.sp),
+//                modifier = Modifier.fillMaxWidth()
+//            )
+//        },
+//        backgroundColor = MaterialTheme.colorScheme.primary
+//    )
+


No need to introduce commented code.

anuragkanojiya1 requested a review from lorenzovngl as a code owner January 3, 2025 18:34

anuragkanojiya1 force-pushed the search-feature branch from 6de88d6 to 40cac60 Compare January 6, 2025 16:16

lorenzovngl force-pushed the search-feature branch from 40cac60 to 0693488 Compare January 8, 2025 20:16

Implemented Material3 SearchBar feature in FoodExpirationDates App

e1bc02d

lorenzovngl force-pushed the search-feature branch from 0693488 to e1bc02d Compare January 8, 2025 20:22

lorenzovngl requested changes Jan 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Material3 SearchBar feature in FoodExpirationDates App #284

Implemented Material3 SearchBar feature in FoodExpirationDates App #284

anuragkanojiya1 commented Jan 3, 2025

lorenzovngl commented Jan 6, 2025

lorenzovngl commented Jan 8, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

lorenzovngl Jan 11, 2025

	searchQuery : MutableState<String>,
	searchQuery : MutableState<String> = mutableStateOf(""),

		showSnackbar = showSnackbar,
		searchQuery = mutableStateOf("")

	showSnackbar = showSnackbar,
	searchQuery = mutableStateOf("")
	showSnackbar = showSnackbar

		navController = rememberNavController(),
		searchQuery = mutableStateOf("")

	navController = rememberNavController(),
	searchQuery = mutableStateOf("")
	navController = rememberNavController()

	searchQuery: MutableState<String>
	searchQuery: MutableState<String> = mutableStateOf("")

		@@ -1,5 +1,6 @@
		package com.lorenzovainigli.foodexpirationdates.view.preview

		import android.annotation.SuppressLint

		startDestination = Screen.AboutScreen.route,
		searchQuery = mutableStateOf("")

Implemented Material3 SearchBar feature in FoodExpirationDates App #284

Are you sure you want to change the base?

Implemented Material3 SearchBar feature in FoodExpirationDates App #284

Conversation

anuragkanojiya1 commented Jan 3, 2025

Related Issue

Description

Implemented Material3 SearchBar

Type of change

lorenzovngl commented Jan 6, 2025

Steps to Rebase search-feature

lorenzovngl commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Steps to Rebase `search-feature`