Break resources in multiple json files & add to vuex module store #91
Conversation
S3B4S
changed the title
S3B4S
changed the title
S3B4S
changed the title
Added JavaScript Questions
add codrops
Add learnjavascript.online & codetogo.io to /javascript
The only thing that I wish to see changed is the UI of the toggle. |
components/Card.vue
Outdated
| } | ||
| </script> | ||
|
|
||
|
|
||
| <style lang="scss" scoped> | ||
| .cardActive { |
There was a problem hiding this comment.
Instead of doing .cardActive we could continue with sass and do:
&Active {
box-shadow:inset 0px 0px 0px 3px #08e5ff;
}I'd prefer it that way, to keep a consistent structure.
components/Sidebar.vue
Outdated
| export default { | ||
| data() { | ||
| return { | ||
| categories: [{ slug: '', title: '' }], |
There was a problem hiding this comment.
Well i guess we should define now if single or double quotes - the codebase is already mixed with both.
There was a problem hiding this comment.
Think we should do this when we implement Prettier, I think I want to do this as the next thing.
components/TableHead.vue
Outdated
| @@ -0,0 +1,38 @@ | |||
| <template lang="pug"> | |||
| tr.tableHead | |||
| th.tableHead--title {{title}} | |||
There was a problem hiding this comment.
Due to this, i realised myself that we apply BEM wrong? Did i always do that :D ?
It's .block__element--modifier 🤔 And I guess I also did .block--element___modifier.
There was a problem hiding this comment.
I guess? I haven't touched CSS at all, I'll leave the BEM changes up to you
pages/_category.vue
Outdated
| .cards | ||
| template(v-for='resource in category.resources') | ||
| Card(:title='resource.title' :desc='resource.desc' :url='resource.url') | ||
| .cards(v-if="cardsShown") |
There was a problem hiding this comment.
Maybe rename from cardsShown to cardsAreVisible ?
There was a problem hiding this comment.
Yeah I think the naming could use some improvements in several places, I've updated this
store/Sidebar.js
Outdated
| }) | ||
|
|
||
| export const getters = { | ||
| isCardsShown: state => state.cardsShown |
There was a problem hiding this comment.
Same as previous comment, cardsAreVisible.
|
So sorry, what is the current state of this? I kinda lost track to be honest. |
|
It's ready to merge, but the UI component (toggle for table/card view) needs to be updated. If you don't have time for that just comment it out & add it back in later. |
|
I will adjust that part tomorrow, just slight modifications are necessary. So merge shall happen tomorrow :) |
I couldn't sleep so I decide to go ahead and do this, based on
feature-i18nbranch which was already using vuex store.Relates to #52
TODO
README.md.