Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema validation) : pydantic migratation #192

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

regislon
Copy link
Collaborator

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Add a reader: reader-<institute>-<campaign>
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

Other information:

Summary

Solve the pydantic issue related to deprecated style.

@regislon regislon requested a review from ghiggi October 10, 2023 07:24
@regislon
Copy link
Collaborator Author

Hi @ghiggi, all tests are passing locally. I've updated some pydantic operations to solve a deprecation issue. A+

@ghiggi ghiggi merged commit 78a27c3 into main Oct 10, 2023
4 of 16 checks passed
@ghiggi
Copy link
Collaborator

ghiggi commented Oct 10, 2023

Thanks @regislon. I merge this and I will try to update the CI tomorrow so to make all tests passing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants