Typo fixes #318
Typo fixes #318
Conversation
|
@tsujan, could you review this old PR - asking because you merged most of my other typo fixes. Also I have two .ui/XML tab-order PRs, in lxqt-session and lxqt-config. |
|
@isf63, thanks for the reminder. Real life problems may interfere with reviewing (and coding, in general). Reminders like this are appreciated, when a PR was made before the previous release. |
| @@ -142,7 +142,7 @@ namespace | |||
| QScopedPointer<SignalHandler> SignalHandler::instance; | |||
| } | |||
|
|
|||
| void Application::listenToUnixSignals(QList<int> const & signoList) | |||
| void Application::listenToUnixSignals(QList<int> const & signalList) | |||
There was a problem hiding this comment.
Also, in the body of the function (this cannot be compiled).
There was a problem hiding this comment.
Btw. this wasn't any typo, but intentional name (signal numbers list) :-)
There was a problem hiding this comment.
Btw. this wasn't any typo
The comment of the function said ... defined in \param signalList....
"signolList" wasn't indicative of a number either. I think @isf63 was right to treat it as a typo, although a harmless one.
There was a problem hiding this comment.
I'll change the identifier and comment to signoList as that is used elsewhere in lxqtapplication.cpp/h.
There was a problem hiding this comment.
I'll change the identifier and comment to signoList as that is used elsewhere in lxqtapplication.cpp/h.
Oh, this is getting complicated for no good reason. That method is public and has a comment; "signoList" has no meaning as a name either. Your previous change was good, and I was going to merge it after a test....
There was a problem hiding this comment.
signoList has a well-defined meaning - 'signo' in Unix/Linux means 'signal number'. Running grep -o -i signo lxqtapplication.cpp there were 13 instances of signo before the recent commit, including another signoList method param.
I agree, getting complicated, but I think it's done.
There was a problem hiding this comment.
signoList has a well-defined meaning...
It may have been used by some devs and then copied. "Linux signo" leads to "Linux signal" in Google and Wikipedia.
there were 13 instances of signo
That's why I said, "That method is public and has a comment....". Anyway, I resigned from reviewing it. Hopefully, another dev will do it.
|
Mostly typo corrections to comments. Double checked and partially reviewed by @tsujan. Merging... |
|
Please NEVER merge a PR that isn't approved by the reviewer(s). |
|
Particularly in this case, which is about a fundamental library, merging without asking others could create bad headaches later. I reverted it in 7b66ae5 |
|
A suggestion: You might want to make another PR that includes only the typos that are NOT inside the codes. |
Typo fixes to comments/text and identifiers. Half of the changes are to CHANGELOG.
Affected files: