Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save custom attributes in archived h5py data files #1691

Open
fanmingyu212 opened this issue Jun 4, 2021 · 3 comments · May be fixed by #1997
Open

save custom attributes in archived h5py data files #1691

fanmingyu212 opened this issue Jun 4, 2021 · 3 comments · May be fixed by #1997

Comments

@fanmingyu212
Copy link
Contributor

ARTIQ Feature Request

Problem this request addresses

Currently users can only save HDF5 datasets in the datasets group of a file. This does not provide a clean way to save custom metadata, which include parameters not fetched as experiment arguments and other experiment parameters (wavemeter frequencies, ion trap voltages, etc.).

Describe the solution you'd like

Some solutions are:

  1. Provide access to HDF5 attributes of datasets and groups
  2. Provide functions to create new groups, and save custom attributes as datasets in custom groups.

Comments/ideas from others would be appreciated. It would be helpful to know how the more advanced ARTIQ users save their metadata in the data file.

@airwoodix
Copy link
Contributor

airwoodix commented Jun 4, 2021

This is linked to #1545 and references therein (in particular #1345).

@sbourdeauducq
Copy link
Member

This does not provide a clean way to save custom metadata, which include parameters not fetched as experiment arguments and other experiment parameters (wavemeter frequencies, ion trap voltages, etc.).

Why not just save those as output datasets? Taking laser wavelength and ion trap voltage measurements is pretty much part of a regular Experiment.

@fanmingyu212
Copy link
Contributor Author

Why not just save those as output datasets? Taking laser wavelength and ion trap voltage measurements is pretty much part of a regular Experiment.

I would prefer to save these variables in a different hdf5 group than "datasets" to organize data better. We also save data such as AOM frequency shift direction, single/double pass, etc. These configurations seem more like attributes than datasets to me, though I agree we could save them as datasets too.

Currently we use a homebuilt server to save hdf5 files in custom format, so I can close this issue if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants