Add API to attach hdf5 attributes to datasets #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
38fa6af to
780398f
Compare
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
73e07e9 to
d7f0ab9
Compare
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
3 times, most recently
from
bcb79e9 to
1685f50
Compare
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
1685f50 to
610d7aa
Compare
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
610d7aa to
7e91760
Compare
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
7e91760 to
9f20ab9
Compare
Cleanup grammar, styles and code Signed-off-by: Egor Savkin <[email protected]> Revise metadata logic Raise on absent keys, raise on wrong types, do not allow metadata on dataset itself. Make tests more real-world-like. Signed-off-by: Egor Savkin <[email protected]> Add HDF5 metadata unit tests Signed-off-by: Egor Savkin <[email protected]> Add HDF5 attributes support to release notes Signed-off-by: yuk <[email protected]> hdf5: Warn when attaching metadata to absent key Signed-off-by: yuk <[email protected]> hdf5: Add demo for saving attributes Signed-off-by: yuk <[email protected]> hdf5: Allow saving custom attributes Signed-off-by: yuk <[email protected]>
thomasfire
force-pushed
the
1978-hdf5-attrs
branch
from
9f20ab9 to
6d5af7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
Related Issue
Closes #1691
Closes #1978
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff, see copyright).Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.Documentation Changes
cd doc/manual/; make html) to ensure no errors.Tests
Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.