Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler test #1901

Closed
wants to merge 2 commits into from

Conversation

Deepskyhunter
Copy link
Contributor

@Deepskyhunter Deepskyhunter commented Jun 2, 2022

ARTIQ Pull Request

Check-condition updated for test_pending_priority

Description of Changes

Goal of the test: Check due dates take precedence over priorities when waiting to prepare.
Problem: Irrelevant case cannot pass the test
Solution: Check is "due_date" exist before assertEqual() to narrow down the cases needed to be compared.

Related Issue

#1888

Type of Changes

Type
🐛 Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Close/update issues.

Code Changes

Documentation Changes

Git Logistics

  • Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
  • Write short & meaningful commit messages. Review each commit for messages (git show). Format:

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

@sbourdeauducq
Copy link
Member

Looks weird (especially the part about ignoring KeyError) and does not address this comment:
#1888 (comment)

Is the comment incorrect? Why?

@Deepskyhunter Deepskyhunter deleted the fix-scheduler-test branch June 13, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants