Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler test #1905

Closed
wants to merge 2 commits into from

Conversation

Deepskyhunter
Copy link
Contributor

…ng_priority

ARTIQ Pull Request

Description of Changes

Goal of the test: Check due dates take precedence over priorities when waiting to prepare.
Problem: Irrelevant case cannot pass the test
Solution: Check is "value" a dictionary before assertEqual() to narrow down the cases needed to be compared.

Related Issue #1888

Type of Changes

Type
🐛 Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Close issues.

Code Changes

  • Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
  • Test your changes or have someone test them. Mention what was tested and how.
  • Add and check docstrings and comments
  • Check, test, and update the unittests in /artiq/test/ or gateware simulations in /artiq/gateware/test

Documentation Changes

Git Logistics

  • Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
  • Write short & meaningful commit messages. Review each commit for messages (git show). Format:
    topic: description. < 50 characters total.
    
    Longer description. < 70 characters per line
    

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

Deepskyhunter added 2 commits June 13, 2022 10:31
As the value of "value" is a dictionary during pending, it is better to check if it is a dictionary for comparing case.
@Deepskyhunter
Copy link
Contributor Author

I misunderstood the meaning of the item inside expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant