-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui/experiments: add custom colors for experiment windows #2590
Conversation
2bccb54
to
ba3eecc
Compare
Would it be possible/straightforward to have the color highlighting only applied to the title bar, or to be able to choose different colors for the title bar and the rest of the window? |
ba3eecc
to
7be774e
Compare
Yes. See updated description. |
1cc9b26
to
0a2a3ca
Compare
Looks like the |
dcae175
to
3816c99
Compare
artiq/dashboard/experiments.py
Outdated
def save_state(self): | ||
self.cleanup_state() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds very hacky (and potentially leading to obscure behavior) that state only gets cleaned up at this point.
artiq/dashboard/experiments.py
Outdated
for attr in attributes: | ||
state_dict = getattr(self, attr) | ||
for expurl in list(state_dict.keys()): | ||
if expurl[:5] == "repo:" and expurl[5:] not in self.explist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain the state cleanup strategy in source code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the cases of experiments inside and outside repos.
3816c99
to
cebb78e
Compare
cebb78e
to
fa265d6
Compare
Signed-off-by: Florian Agbuya <[email protected]>
fa265d6
to
6b61cce
Compare
ARTIQ Pull Request
Description of Changes
Adds support for custom title bar and windows color in the experiment windows. Users can now select, apply, and reset these colors from the context menu:
_ArgumentEditor
and_ExperimentDock
to apply colors to widgets._ThemedTitleBar
style to override theMDISubWindow
title bar.ExperimentManager
manages color storage and retrieval, persisting them across sessions.TODO: clean up storage when experiments get deleted (Other PR)
Color Menu
Title Bar
Window
Dark Theme Example
Windows Minimized
Related Issue
#2576
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff
, see copyright).Code Changes
flake8
to check code style (follow PEP-8 style).flake8
has issues with parsing Migen/gateware code, ignore as necessary.Documentation Changes
nix build .#artiq-manual-html; nix build .#artiq-manual-pdf
) to ensure no errors.Git Logistics
git rebase --interactive
). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show
). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.