-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial porting for mbed #6
Initial porting for mbed #6
Conversation
- renamed string.h to cdr_string.h to avoid a link search path problem, which is caused by the same issue below. ARMmbed/mbed-cli#917 - added "return true;" at the tail of serializeIntoUdcrBuffer() to avoid a warning, which is treated as an error by Mbed online compiler (Arm Compiler).
@smoriemb thank you so much for your contribution!! I have one question to your commit, because I'm not so familiar with micro-CDR. |
It is not common, I think. This modification is just a workaround for the Web compiler. I found this problem only in the Web compiler, and there is no problem with CLI2(GCC). |
Hmmm, I'm thinking deeply. Renaming third-party files just for the Mbed web compiler doesn't seem reasonable,,, |
I found Micro-CDR/include/ucdr/types/string.h is no longer included the latest version of Micro-CDR officially published by eProsima. And also, header files seemed to be merged to one file. I think that our possible options are 1) to allow file renaming and 2) to follow the update to Micro-CDR. |
we decided to merge this PR as it is. |
* minor changes required for compilation with Tasking Compiler for Infineon Aurix * fixing errors occurring when activating verbose outputs * clang-format Co-authored-by: Alexandru Kampmann <[email protected]>
As I've reported below, I have some trivial problems to compile your mros2 for Mbed environment.
https://www.slideshare.net/smorita1/mros2-on-mbed
We know to implement an OS abstraction layer for the potability. But, it might be beneficial to port it , without such a layer, to another OS directly, as a first step.