Skip to content

Commit

Permalink
chore: edit TODO's
Browse files Browse the repository at this point in the history
  • Loading branch information
maartyman committed Jan 20, 2025
1 parent a8d5703 commit 2e9b93a
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
4 changes: 2 additions & 2 deletions packages/actor-query-operation-group/lib/GroupsIterator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class GroupIterator extends AsyncIterator<Bindings> {
this.context = context;
this.mediatorBindingsAggregatorFactory = mediatorBindingsAggregatorFactory;

// TODO [2024-11-21]: this is a bit of a hack, we should not be listening to the data event
// TODO [2024-06-01]: this is a bit of a hack, we should not be listening to the data event

Check failure on line 53 in packages/actor-query-operation-group/lib/GroupsIterator.ts

View workflow job for this annotation

GitHub Actions / lint

There is a TODO that is past due date: 2024-06-01. this is a bit of a hack, we should not be listening to the data event
let dataCounter = 0;
inputBindings.on('data', (bindings: Bindings) => {
dataCounter++;
Expand Down Expand Up @@ -90,7 +90,7 @@ export class GroupIterator extends AsyncIterator<Bindings> {
this.nextBindings = null;
return bindings;
}
// TODO [2024-11-21]: maybe make sure this is done in round robin fashion
// TODO [2024-09-01]: maybe make sure this is done in round robin fashion

Check failure on line 93 in packages/actor-query-operation-group/lib/GroupsIterator.ts

View workflow job for this annotation

GitHub Actions / lint

There is a TODO that is past due date: 2024-09-01. maybe make sure this is done in round robin fashion
for (const group of this.groups.values()) {
if (group.groupBuffer) {
continue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@ export class StreamQuerySources implements IQuerySource {
}

const variables = getVariables(<Algebra.Pattern>operation);
// TODO [2025-01-01]: how to handle metadata correctly
// TODO [2025-04-01]: how to handle metadata correctly
let accumulatedMetadata: MetadataBindings = {
state: new MetadataValidationState(),
cardinality: { type: 'estimate', value: 1 },
variables: variables.map(variable =>
// TODO [2025-01-01]: make sure canBeUndef is set correctly
// TODO [2025-04-01]: make sure canBeUndef is set correctly
({ variable, canBeUndef: false })),
};
let first = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import { Factory } from 'sparqlalgebrajs';
import type { Algebra } from 'sparqlalgebrajs';

export class StreamingQuerySourceRdfJs extends StreamingQuerySource {
// TODO [2025-01-01]: generalize store type
public store: StreamingStore<Quad>;
private registeredQueries: number;
protected readonly selectorShape: FragmentSelectorShape;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ export class ActorRdfJoinInnerMemoryBind extends ActorRdfJoin {
const receiveItemCostRemaining = remainingRequestItemTimes
.reduce((sum, element) => sum + element, 0);

// TODO [2025-01-01]: persistedItems is not yet implemented
// TODO [2025-06-01]: persistedItems is not yet implemented
return passTestWithSideData({
iterations: metadatas[0].cardinality.value * cardinalityRemaining,
persistedItems: 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class ActorSourceWatchPolling extends ActorSourceWatch {

let etag = action.metadata.etag;
const checkForChanges = (): void => {
// TODO [2024-12-19]: what if the source doesn't support HEAD requests, if it's a SPARQL endpoint for example?
// TODO [2024-03-01]: what if the source doesn't support HEAD requests, if it's a SPARQL endpoint for example?
this.mediatorHttp.mediate(
{
context: action.context,
Expand All @@ -61,7 +61,7 @@ export class ActorSourceWatchPolling extends ActorSourceWatch {
pollingStartTime = Date.now() + (pollingPeriod - Number.parseInt(action.metadata.age, 10)) * 1000;
}

// TODO [2024-12-01]: have more specific error handling for example 304: Not Modified should not emit 'delete'
// TODO [2024-08-01]: have more specific error handling for example 304: Not Modified should not emit 'delete'
if (!responseHead.ok) {
events.emit('delete');
}
Expand Down
4 changes: 2 additions & 2 deletions packages/bus-source-watch/lib/ActorSourceWatch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { Actor } from '@comunica/core';
* An incremunica actor for source-watch events.
*
* Actor types:
* * Input: IActionSourceWatch: // TODO: fill in.
* * Input: IActionSourceWatch: // TODO [2024-12-01]: fill in.
* * Test: <none>
* * Output: IActorSourceWatchOutput: // TODO: fill in.
* * Output: IActorSourceWatchOutput: // TODO [2024-12-01]: fill in.
*
* @see IActionSourceWatch
* @see IActorSourceWatchOutput
Expand Down

0 comments on commit 2e9b93a

Please sign in to comment.