v1.9.1 (#297)

* fix: preferences type conversion error

* chore: update fastlane

* chore: bump application version

* chore: add changelogs

* chore: update RELEASING.md

CHANGELOG.md

@@ -4,7 +4,13 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## 1.9.0 - 2024-12-09
+## 1.9.1 - 2024-12-11
+
+### Fixed
+
+- Crash when loading the theming preference
+
+## 1.9.0 - 2024-12-11
 
 ### Added
 

Gemfile.lock

@@ -10,16 +10,16 @@ GEM
     artifactory (3.0.17)
     atomos (0.1.3)
     aws-eventstream (1.3.0)
-    aws-partitions (1.1013.0)
-    aws-sdk-core (3.213.0)
+    aws-partitions (1.1021.0)
+    aws-sdk-core (3.214.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.992.0)
       aws-sigv4 (~> 1.9)
       jmespath (~> 1, >= 1.6.1)
     aws-sdk-kms (1.96.0)
       aws-sdk-core (~> 3, >= 3.210.0)
       aws-sigv4 (~> 1.5)
-    aws-sdk-s3 (1.173.0)
+    aws-sdk-s3 (1.176.0)
       aws-sdk-core (~> 3, >= 3.210.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.5)
@@ -68,7 +68,7 @@ GEM
     faraday_middleware (1.2.1)
       faraday (~> 1.0)
     fastimage (2.3.1)
-    fastlane (2.225.0)
+    fastlane (2.226.0)
       CFPropertyList (>= 2.3, < 4.0.0)
       addressable (>= 2.8, < 3.0.0)
       artifactory (~> 3.0)
@@ -108,7 +108,7 @@ GEM
       tty-spinner (>= 0.8.0, < 1.0.0)
       word_wrap (~> 1.0.0)
       xcodeproj (>= 1.13.0, < 2.0.0)
-      xcpretty (~> 0.3.0)
+      xcpretty (~> 0.4.0)
       xcpretty-travis-formatter (>= 0.0.3, < 2.0.0)
     fastlane-sirp (1.0.0)
       sysrandom (~> 1.0)
@@ -150,11 +150,11 @@ GEM
       os (>= 0.9, < 2.0)
       signet (>= 0.16, < 2.a)
     highline (2.0.3)
-    http-cookie (1.0.7)
+    http-cookie (1.0.8)
       domain_name (~> 0.5)
     httpclient (2.8.3)
     jmespath (1.6.2)
-    json (2.8.2)
+    json (2.9.0)
     jwt (2.9.3)
       base64
     mini_magick (4.13.2)
@@ -175,7 +175,7 @@ GEM
       uber (< 0.2.0)
     retriable (3.1.2)
     rexml (3.3.9)
-    rouge (2.0.7)
+    rouge (3.28.0)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
     security (0.1.5)
@@ -206,8 +206,8 @@ GEM
       colored2 (~> 3.1)
       nanaimo (~> 0.4.0)
       rexml (>= 3.3.6, < 4.0)
-    xcpretty (0.3.0)
-      rouge (~> 2.0.7)
+    xcpretty (0.4.0)
+      rouge (~> 3.28.0)
     xcpretty-travis-formatter (1.0.1)
       xcpretty (~> 0.2, >= 0.0.7)
 

RELEASING.md

@@ -30,5 +30,5 @@
 
 ### Screenshots
 
-- [ ] Update [`screenshotNotes`](lib/common/constants/notes.dart)
+- [ ] Update screenshot [notes](lib/common/constants/notes.dart) and [labels](lib/common/constants/labels.dart)
 - [ ] Update fastlane screenshots

fastlane/metadata/android/en-US/changelogs/201.txt

@@ -0,0 +1,2 @@
+FIXED
+- Crash when loading the theming preference

fastlane/metadata/android/fr-FR/changelogs/201.txt

@@ -0,0 +1,2 @@
+CORRIGÉ
+- Crash lors du chargement de la préférence du thème

lib/common/navigation/app_bars/notes_app_bar.dart

@@ -17,7 +17,7 @@ import 'package:localmaterialnotes/routing/routes/notes/notes_route.dart';
 import 'package:localmaterialnotes/routing/routes/shell/shell_route.dart';
 import 'package:localmaterialnotes/utils/keys.dart';
 
-import '../../../providers/preferences/watched_preferences.dart';
+import '../../preferences/watched_preferences.dart';
 
 /// Notes list and bin's app bar.
 ///

lib/common/preferences/preferences_utils.dart

@@ -1,4 +1,5 @@
 import 'package:flutter_secure_storage/flutter_secure_storage.dart';
+import 'package:localmaterialnotes/common/constants/constants.dart';
 import 'package:localmaterialnotes/common/preferences/preference_key.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
@@ -58,7 +59,17 @@ class PreferencesUtils {
       throw ArgumentError('The preference is securely stored, use getSecure() instead');
     }
 
-    return _preferences.get(preferenceKey.name) as T?;
+    try {
+      return _preferences.get(preferenceKey.name) as T?;
+    }
+    // On type conversion error, reset the preference to its default value
+    on TypeError catch (error) {
+      logger.e('Conversion error while getting the value of a preference', error, error.stackTrace);
+
+      preferenceKey.reset();
+
+      return null;
+    }
   }
 
   /// Returns the value of the securely stored [preferenceKey].

lib/pages/settings/pages/settings_accessibility_page.dart

@@ -6,8 +6,8 @@ import 'package:localmaterialnotes/common/constants/paddings.dart';
 import 'package:localmaterialnotes/common/navigation/app_bars/basic_app_bar.dart';
 import 'package:localmaterialnotes/common/navigation/top_navigation.dart';
 import 'package:localmaterialnotes/common/preferences/preference_key.dart';
+import 'package:localmaterialnotes/common/preferences/watched_preferences.dart';
 import 'package:localmaterialnotes/providers/preferences/preferences_provider.dart';
-import 'package:localmaterialnotes/providers/preferences/watched_preferences.dart';
 import 'package:localmaterialnotes/utils/keys.dart';
 import 'package:localmaterialnotes/utils/locale_utils.dart';
 import 'package:settings_tiles/settings_tiles.dart';

lib/pages/settings/pages/settings_appearance_page.dart

@@ -9,9 +9,9 @@ import 'package:localmaterialnotes/common/enums/localization_completion.dart';
 import 'package:localmaterialnotes/common/navigation/app_bars/basic_app_bar.dart';
 import 'package:localmaterialnotes/common/navigation/top_navigation.dart';
 import 'package:localmaterialnotes/common/preferences/preference_key.dart';
+import 'package:localmaterialnotes/common/preferences/watched_preferences.dart';
 import 'package:localmaterialnotes/l10n/app_localizations/app_localizations.g.dart';
 import 'package:localmaterialnotes/providers/preferences/preferences_provider.dart';
-import 'package:localmaterialnotes/providers/preferences/watched_preferences.dart';
 import 'package:localmaterialnotes/utils/keys.dart';
 import 'package:localmaterialnotes/utils/locale_utils.dart';
 import 'package:localmaterialnotes/utils/theme_utils.dart';

lib/pages/settings/pages/settings_behavior_page.dart

@@ -11,8 +11,8 @@ import 'package:localmaterialnotes/common/preferences/preference_key.dart';
 import 'package:localmaterialnotes/utils/keys.dart';
 import 'package:settings_tiles/settings_tiles.dart';
 
+import '../../../common/preferences/watched_preferences.dart';
 import '../../../providers/preferences/preferences_provider.dart';
-import '../../../providers/preferences/watched_preferences.dart';
 
 /// Settings related to the behavior of the application.
 class SettingsBehaviorPage extends ConsumerStatefulWidget {

lib/providers/preferences/preferences_provider.dart

@@ -1,4 +1,4 @@
-import 'package:localmaterialnotes/providers/preferences/watched_preferences.dart';
+import 'package:localmaterialnotes/common/preferences/watched_preferences.dart';
 import 'package:riverpod_annotation/riverpod_annotation.dart';
 
 part 'preferences_provider.g.dart';

makefile

@@ -12,6 +12,7 @@ gen_build:
 gen_watch:
 	dart run build_runner watch --delete-conflicting-outputs
 
+
 # Assets generation
 .PHONY: gen_icon gen_splash gen_full_descriptions
 
@@ -24,18 +25,31 @@ gen_splash:
 gen_full_descriptions:
 	py scripts/generate_full_description.py
 
+
 # Tests
 .PHONY: test_all
 
 test_all:
 	patrol test -t integration_test --dart-define=INTEGRATION_TEST=true
 
+
 # Build
 .PHONY: release
 
 release:
 	flutter build apk --release
 
+
+# Update
+.PHONY: update_flutter update_fastlane
+
+update_flutter:
+	flutter upgrade --force
+
+update_fastlane:
+	bundle update fastlane
+
+
 # Miscellaneous
 .PHONY: clean
 

pubspec.yaml

@@ -2,7 +2,7 @@ name: localmaterialnotes
 description: Simple, local, material design notes
 repository: https://github.com/maelchiotti/LocalMaterialNotes
 
-version: 1.9.0+20
+version: 1.9.1+21
 publish_to: none
 
 environment: