Skip to content

Commit

Permalink
Improved implementation and tests of Unable to Scream
Browse files Browse the repository at this point in the history
  • Loading branch information
@markort147
markort147 committed Jan 18, 2025
1 parent be21701 commit ce74783
Show file tree
Hide file tree
Showing 3 changed files with 116 additions and 85 deletions.
9 changes: 5 additions & 4 deletions Mage.Sets/src/mage/cards/u/UnableToScream.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public UnableToScream(UUID ownerId, CardSetInfo setInfo) {
this.getSpellAbility().addEffect(new AttachEffect(Outcome.Detriment));
this.addAbility(new EnchantAbility(auraTarget));

// Enchanted creature loses all abilities and is a Toy artifact creature with base power and toughness 0/2
// in addition to its other types.
// Enchanted creature loses all abilities and is a Toy artifact creature with base power and toughness 0/2 in addition to its other types.
Ability ability = new SimpleStaticAbility(new LoseAllAbilitiesAttachedEffect(AttachmentType.AURA));
ability.addEffect(new AddCardSubtypeAttachedEffect(SubType.TOY, AttachmentType.AURA).setText(" and is a Toy"));
ability.addEffect(new AddCardTypeAttachedEffect(CardType.ARTIFACT, AttachmentType.AURA).setText(" artifact creature"));
Expand Down Expand Up @@ -78,12 +77,14 @@ public boolean checksEventType(GameEvent event, Game game) {
@Override
public boolean applies(GameEvent event, Ability source, Game game) {
Permanent aura = game.getPermanent(source.getSourceId());
if (aura == null)
if (aura == null) {
return false;
}

Permanent creature = game.getPermanent(aura.getAttachedTo());
if (creature == null)
if (creature == null) {
return false;
}

return creature.isFaceDown(game) && event.getTargetId().equals(creature.getId());
}
Expand Down
189 changes: 109 additions & 80 deletions Mage.Tests/src/test/java/org/mage/test/cards/single/dsk/UnableToScreamTest.java
View file
Original file line number Diff line number Diff line change
@@ -1,125 +1,154 @@
package org.mage.test.cards.single.dsk;

import mage.abilities.Ability;
import mage.abilities.mana.GreenManaAbility;
import mage.cards.Card;
import mage.constants.*;
import org.junit.Assert;
import org.junit.Test;
import org.mage.test.serverside.base.CardTestPlayerBase;

import java.util.Arrays;
import java.util.List;
import java.util.Collections;
import java.util.HashSet;
import java.util.stream.Collectors;

/**
* @author markort147
*/
public class UnableToScreamTest extends CardTestPlayerBase {

/*
* Unable to Scream {U}
* Enchantment - Aura
* Enchant creature
* Enchanted creature loses all abilities and is a Toy artifact creature with base power and toughness 0/2 in addition to its other types.
* As long as enchanted creature is face down, it can't be turned face up.
*/
public static final String UNABLE_TO_SCREAM = "Unable to Scream";

@Test
public void cannotTurnFaceUpTest() {
String akroma = "Akroma, Angel of Fury";
String breakOpen = "Break Open";
/*
* Appetite for the Unnatural {2}{G}
* Instant
* Destroy target artifact or enchantment. You gain 2 life.
*/
public static final String APPETITE_FOR_THE_UNNATURAL = "Appetite for the Unnatural";


addCard(Zone.HAND, playerB, akroma);
// Cast a spell that would turn the creature face up, but Unable to Scream negates the effect.
// After removing Unable to Scream, cast the spell again and the effect applies correctly.
@Test
public void preventFromTurningFaceUpTest() {
/*
* Akroma, Angel of Fury {5}{R}{R}{R}
* Creature - Legendary Angel
* 6/6
* Akroma, Angel of Fury can't be countered.
* Flying
* Trample
* Protection from white and from blue.
* {R}: Akroma, Angel of Fury gets +1/+0 until end of turn.
* Morph {3}{R}{R}{R}
*/
final String akromaAngelOfFury = "Akroma, Angel of Fury";

/*
* Break Open {1}{R}
* Instant
* Turn target face-down creature an opponent controls face up.
*/
final String breakOpen = "Break Open";

setStrictChooseMode(true);

addCard(Zone.HAND, playerB, akromaAngelOfFury);
addCard(Zone.HAND, playerB, APPETITE_FOR_THE_UNNATURAL);
addCard(Zone.BATTLEFIELD, playerB, "Mountain", 6);
addCard(Zone.BATTLEFIELD, playerB, "Forest", 3);

addCard(Zone.HAND, playerA, UNABLE_TO_SCREAM);
addCard(Zone.HAND, playerA, breakOpen, 1);
addCard(Zone.HAND, playerA, breakOpen, 2);
addCard(Zone.BATTLEFIELD, playerA, "Island", 2);
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 1);

castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerB, akroma + " using Morph");
// prepare the face down creature
castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerB, akromaAngelOfFury + " using Morph");
// attach Unable to Scream to it
castSpell(3, PhaseStep.PRECOMBAT_MAIN, playerA, UNABLE_TO_SCREAM, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), true);
// cast a spell that would turn the creature face up
castSpell(3, PhaseStep.PRECOMBAT_MAIN, playerA, breakOpen, EmptyNames.FACE_DOWN_CREATURE.getTestCommand());

setStopAt(4, PhaseStep.BEGIN_COMBAT);
execute();

assertPermanentCount(playerB, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), 1);
assertPowerToughness(playerB, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), 0, 2);
}

@Test
public void turnFaceUpAfterRemovingAuraTest() {
String akroma = "Akroma, Angel of Fury";
String breakOpen = "Break Open";
String removal = "Appetite for the Unnatural";
// the creature is still face down
checkPermanentCount("Face down creature is on the battlefield", 3, PhaseStep.BEGIN_COMBAT, playerB, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), 1);
checkPermanentCount("Akroma is not on the battlefield", 3, PhaseStep.BEGIN_COMBAT, playerB, akromaAngelOfFury, 0);

addCard(Zone.HAND, playerB, akroma);
addCard(Zone.BATTLEFIELD, playerB, "Mountain", 6);
addCard(Zone.HAND, playerB, removal);
addCard(Zone.BATTLEFIELD, playerB, "Forest", 3);

addCard(Zone.HAND, playerA, UNABLE_TO_SCREAM);
addCard(Zone.HAND, playerA, breakOpen, 1);
addCard(Zone.BATTLEFIELD, playerA, "Island", 2);
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 1);

castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerB, akroma + " using Morph");
castSpell(3, PhaseStep.PRECOMBAT_MAIN, playerA, UNABLE_TO_SCREAM, EmptyNames.FACE_DOWN_CREATURE.getTestCommand());
castSpell(4, PhaseStep.PRECOMBAT_MAIN, playerB, removal, UNABLE_TO_SCREAM);
// destroy Unable to Scream
castSpell(4, PhaseStep.PRECOMBAT_MAIN, playerB, APPETITE_FOR_THE_UNNATURAL, UNABLE_TO_SCREAM);
// cast a spell that would turn the creature face up
castSpell(5, PhaseStep.PRECOMBAT_MAIN, playerA, breakOpen, EmptyNames.FACE_DOWN_CREATURE.getTestCommand());

// now the creature is turned face up
checkPermanentCount("Face down creature is not on the battlefield", 5, PhaseStep.BEGIN_COMBAT, playerB, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), 0);
checkPermanentCount("Akroma is on the battlefield", 5, PhaseStep.BEGIN_COMBAT, playerB, akromaAngelOfFury, 1);

setStopAt(5, PhaseStep.BEGIN_COMBAT);
execute();

assertPermanentCount(playerB, EmptyNames.FACE_DOWN_CREATURE.getTestCommand(), 0);
assertPermanentCount(playerB, akroma, 1);
}


// Unable to Scream changes type, subtype and base stats of a creature.
// After removing Unable to Scream, the creature restores its type, subtype, and base stats.
@Test
public void becomesToyTest() {
String elves = "Llanowar Elves";
public void becomesEffectTest() {
/*
* Llanowar Elves {G}
* Creature - Elf Druid
* 1/1
* {T}: Add {G}.
*/
final String llanowarElves = "Llanowar Elves";

setStrictChooseMode(true);

addCard(Zone.HAND, playerB, APPETITE_FOR_THE_UNNATURAL);
addCard(Zone.BATTLEFIELD, playerB, llanowarElves);
addCard(Zone.BATTLEFIELD, playerB, "Forest", 3);

addCard(Zone.BATTLEFIELD, playerB, elves);
addCard(Zone.HAND, playerA, UNABLE_TO_SCREAM);
addCard(Zone.BATTLEFIELD, playerA, "Island", 2);

castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, UNABLE_TO_SCREAM, elves);

setStopAt(1, PhaseStep.BEGIN_COMBAT);
execute();

assertPermanentCount(playerB, elves, 1);
assertPermanentCount(playerA, UNABLE_TO_SCREAM, 1);
assertPowerToughness(playerB, elves, 0, 2);
assertAbility(playerB, elves, new GreenManaAbility(), false);
List<CardType> types = Arrays.asList(CardType.CREATURE, CardType.ARTIFACT);
List<SubType> subTypes = Arrays.asList(SubType.TOY, SubType.ELF, SubType.DRUID);
types.forEach(t ->
subTypes.forEach(st ->
assertType(elves, t, st)
)
// attach Unable to Scream to the creature
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, UNABLE_TO_SCREAM, llanowarElves);

// the creature is an artifact creature, toy elf druid with base stats 0/2
runCode("The creature is an artifact creature, toy elf druid with base stats 0/2", 1, PhaseStep.BEGIN_COMBAT, playerB,
(info, player, game) -> {
Card elves = game.getBattlefield().getAllActivePermanents().stream().filter(p -> p.getName().equals(llanowarElves)).findAny().orElse(null);
Assert.assertNotNull("The creature must be on the battlefield", elves);
Assert.assertEquals("The creature must have base power 0", 0, elves.getPower().getValue());
Assert.assertEquals("The creature must have base toughness 2", 2, elves.getToughness().getValue());
Assert.assertTrue("The creature must have lost its abilities", elves.getAbilities(game).isEmpty());
Assert.assertEquals("The creature must be an artifact creature", new HashSet<>(Arrays.asList(CardType.ARTIFACT, CardType.CREATURE)), new HashSet<>(elves.getCardType(game)));
Assert.assertEquals("The creature must be a Toy Elf Druid", new HashSet<>(Arrays.asList(SubType.TOY, SubType.ELF, SubType.DRUID)), new HashSet<>(elves.getSubtype(game)));
}
);
}

@Test
public void removeAuraTest() {
String elves = "Llanowar Elves";
String removal = "Appetite for the Unnatural";

addCard(Zone.BATTLEFIELD, playerB, elves);
addCard(Zone.BATTLEFIELD, playerB, "Forest", 3);
addCard(Zone.HAND, playerB, removal);
addCard(Zone.HAND, playerA, UNABLE_TO_SCREAM);
addCard(Zone.BATTLEFIELD, playerA, "Island", 2);

castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, UNABLE_TO_SCREAM, elves);
castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerB, removal, UNABLE_TO_SCREAM);
// destroy Unable to Scream
castSpell(2, PhaseStep.PRECOMBAT_MAIN, playerB, APPETITE_FOR_THE_UNNATURAL, UNABLE_TO_SCREAM);

// the creature is a creature, elf druid with base stats 1/1
runCode("The creature is creature, toy elf druid with base stats 1/1", 2, PhaseStep.BEGIN_COMBAT, playerB,
(info, player, game) -> {
Card elves = game.getBattlefield().getAllActivePermanents().stream().filter(p -> p.getName().equals(llanowarElves)).findAny().orElse(null);
Assert.assertNotNull("The creature must be on the battlefield", elves);
Assert.assertEquals("The creature must have base power 1", 1, elves.getPower().getValue());
Assert.assertEquals("The creature must have base toughness 1", 1, elves.getToughness().getValue());
Assert.assertTrue("The creature must have restored its abilities", elves.getAbilities(game).stream().map(Ability::getClass).collect(Collectors.toList()).contains(GreenManaAbility.class));
Assert.assertEquals("The creature must be just a creature", Collections.singleton(CardType.CREATURE), new HashSet<>(elves.getCardType(game)));
Assert.assertEquals("The creature must be an Elf Druid", new HashSet<>(Arrays.asList(SubType.ELF, SubType.DRUID)), new HashSet<>(elves.getSubtype(game)));
}
);

setStopAt(2, PhaseStep.BEGIN_COMBAT);
execute();

assertPermanentCount(playerB, elves, 1);
assertPermanentCount(playerA, UNABLE_TO_SCREAM, 0);

assertPowerToughness(playerB, elves, 1, 1);
assertType(elves, CardType.CREATURE, true);
assertType(elves, CardType.ARTIFACT, false);
assertSubtype(elves, SubType.ELF);
assertSubtype(elves, SubType.DRUID);
assertNotSubtype(elves, SubType.TOY);
assertAbility(playerB, elves, new GreenManaAbility(), true);
}
}
3 changes: 2 additions & 1 deletion ...rc/main/java/mage/abilities/effects/common/continuous/LoseAllAbilitiesAttachedEffect.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ public boolean apply(Game game, Ability source) {
Permanent creature = game.getPermanent(equipment.getAttachedTo());
if (creature != null) {
creature.removeAllAbilities(source.getSourceId(), game);
return true;
}
}
return true;
return false;
}

private void setText() {
Expand Down

0 comments on commit ce74783

Please sign in to comment.