Dilation #34
Draft
Dilation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, the value of the "can-dilate" key in the version message payload contains a list of versions supported by the client.
meejah
reviewed
Mar 14, 2023
meejah
reviewed
Mar 14, 2023
| message). | ||
| The version message payload has a key called `can-dilate` that has a | ||
| list of versions supported by a particular version of the client (eg: | ||
| ["1", "2"]). After receiving the version message from the other |
There was a problem hiding this comment.
This kind of gets rid of how the negotiation actually happens .. can we leave the use-version and versions details (i.e. it no longer says how to compute the "shared" versions or who decides which version to use and how that's communicated.
There was a problem hiding this comment.
I'm not sure I understand your point, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request of the
dilationbranch, where we accumulate all our Dilation related changes.