fix(decrypt): prevent extra clones while decrypting chunks #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
force-pushed
the
prevent_extra_clones
branch
2 times, most recently
from
a557f96 to
cfa0c1f
Compare
joshuef
reviewed
Dec 19, 2023
src/decrypt.rs
Outdated
| )) | ||
| // we can pass &src_hashes since Rayon uses scopes under the hood which guarantees that threads are | ||
| // joined before src_hashes goes out of scope | ||
| let bytes = decrypt_chunk(c.index, c.content.clone(), &src_hashes)?; |
There was a problem hiding this comment.
does this not work also? I dont see where c is being used after this?
Suggested change
| let bytes = decrypt_chunk(c.index, c.content.clone(), &src_hashes)?; | |
| let bytes = decrypt_chunk(c.index, c.content, &src_hashes)?; |
RolandSherwin
force-pushed
the
prevent_extra_clones
branch
from
cfa0c1f to
f3a1b5e
Compare
joshuef
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.