NOISSUE - Add Things Migration #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
requested changes
Mar 28, 2023
cmd/migrate/main.go
Outdated
| @@ -0,0 +1,39 @@ | |||
| package main | |||
There was a problem hiding this comment.
No need for a migrate subdirectory, cmd/main.go is just fine.
migrate/migrate.go
Outdated
| func connectToThingsDB(dbConfig mf13thingspostgres.Config) *sqlx.DB { | ||
| db, err := mf13thingspostgres.Connect(dbConfig) | ||
| if err != nil { | ||
| log.Panic(fmt.Errorf("Failed to connect to things postgres: %s", err)) |
cmd/migrate/main.go
Outdated
| // Root Flags | ||
| rootCmd.PersistentFlags().StringVarP(&cfg.FromVersion, "fromversion", "f", "0.13.0", "mainflux version you want to migrate from") | ||
| rootCmd.PersistentFlags().StringVarP(&cfg.ToVersion, "toversion", "t", "0.14.0", "mainflux version you want to migrate to") | ||
| rootCmd.PersistentFlags().StringVarP(&cfg.Operation, "operation", "o", "export", "export dataor import data to a new mainflux deployment") |
migrate/users/minisdk.go
Outdated
| } | ||
| o := limit | ||
| limit = util.UpdateLimit(usersPage.Total) | ||
| for o < usersPage.Total { |
There was a problem hiding this comment.
The idea of fetching everything from the DB to the RAM. That's the point of pagination. This should be more like a pipe where we stream (channel) the batch, and publish it to the next phase to process. Bear in mind that we'll need to remember "last saved" so in case something goes wrong we don't need to start over.
rodneyosodo
changed the title
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
rodneyosodo
force-pushed
the
NOISSUE-thingsmigration
branch
from
1c3819f to
809adf8
Compare
Signed-off-by: rodneyosodo <[email protected]>
SammyOina
suggested changes
Jul 27, 2023
cmd/main.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| migrationDuration = 1 * time.Hour |
There was a problem hiding this comment.
this might not be a good idea to set a fixed value because we don't know how long it could take for different sizes of migrations
internal/query.go
Outdated
Comment on lines
14
to
21
| switch { | ||
| case total <= limit1000: | ||
| return defLimit | ||
| case total <= limit10000: | ||
| return limit1000 | ||
| case total <= limit100000: | ||
| return limit10000 | ||
| case total <= limit1000000: |
There was a problem hiding this comment.
this can be reduced a mathematical statement
migrate/migrate.go
Outdated
|
|
||
| func Migrate(ctx context.Context, cfg migrations.Config, logger logger.Logger) { | ||
| go func() { | ||
| log.Println(http.ListenAndServe("localhost:6060", nil)) |
|
regarding the token timeout, you can add to documentation on how to change env var to create a longer duration token for migration purposes |
Signed-off-by: rodneyosodo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rodneyosodo [email protected]
KNOWN ISSUES