Skip to content

Commit

Permalink
Merge pull request #2590 from mainmatter/renovate/eslint-plugin-qunit…
Browse files Browse the repository at this point in the history
…-8.x

chore(deps): update dependency eslint-plugin-qunit to v8
  • Loading branch information
BobrImperator authored Sep 26, 2023
2 parents d177611 + a8d6d5b commit 2708278
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 16 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ module.exports = {
'no-var': 'off',
'prefer-template': 'off',
'quotes': 'off',
'semi': 'off'
'semi': 'off',
'qunit/require-expect': ['error', 'except-simple'],
},
overrides: [
// node files
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- test-esa
- classic-test-app
- test-app
- ember-simple-auth

steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
Expand Down
2 changes: 1 addition & 1 deletion packages/classic-test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"eslint-config-simplabs": "0.4.0",
"eslint-plugin-ember": "11.11.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-qunit": "7.3.4",
"eslint-plugin-qunit": "8.0.0",
"express": "4.18.2",
"glob": "10.3.7",
"handlebars": "4.7.8",
Expand Down
1 change: 1 addition & 0 deletions packages/ember-simple-auth/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist/
6 changes: 3 additions & 3 deletions packages/ember-simple-auth/src/session-stores/cookie.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import BaseStore from './base';
import objectsAreEqual from '../utils/objects-are-equal';
import { isTesting } from '@embroider/macros';

const persistingProperty = function (beforeSet = function () {}) {
const persistingProperty = function(beforeSet = function() {}) {
return computed({
get(key) {
return this.get(`_${key}`);
Expand Down Expand Up @@ -112,7 +112,7 @@ export default BaseStore.extend({
@public
*/
_cookieName: 'ember_simple_auth-session',
cookieName: persistingProperty(function () {
cookieName: persistingProperty(function() {
this._oldCookieName = this._cookieName;
}),

Expand Down Expand Up @@ -142,7 +142,7 @@ export default BaseStore.extend({
@public
*/
_cookieExpirationTime: null,
cookieExpirationTime: persistingProperty(function (key, value) {
cookieExpirationTime: persistingProperty(function(key, value) {
// When nulling expiry time on purpose, we need to clear the cached value.
// Otherwise, `_calculateExpirationTime` will reuse it.
if (isNone(value)) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"eslint-config-simplabs": "0.4.0",
"eslint-plugin-ember": "11.11.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-qunit": "7.3.4",
"eslint-plugin-qunit": "8.0.0",
"express": "4.18.2",
"fastboot-app-server": "4.1.1",
"glob": "10.3.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-esa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"eslint-config-simplabs": "0.4.0",
"eslint-plugin-ember": "11.11.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-qunit": "7.3.4",
"eslint-plugin-qunit": "8.0.0",
"express": "4.18.2",
"glob": "10.3.7",
"handlebars": "4.7.8",
Expand Down
18 changes: 9 additions & 9 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2708278

Please sign in to comment.