Skip to content

Commit

Permalink
Add tenderly-related checks (#26)
Browse files Browse the repository at this point in the history
  • Loading branch information
SidestreamColdMelon authored Feb 14, 2024
1 parent 9ecb1b1 commit 45b65c3
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions .wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ Solmate
setIlkAutoLineDebtCeiling
ESM
testnet
testnets
authing
hardcoded
fileables
Expand Down
5 changes: 5 additions & 0 deletions spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,14 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Ensure spell is verified on etherscan
* [ ] Ensure local tests PASS against deployed spell run via the deploy script
* [ ] Push auto-generated commit
* Cast spell on a newly created Tenderly Testnet
* [ ] Create testnet and cast deployed spell there using `make cast-on-tenderly spell=0x...` command (or a CI trigger)
* [ ] Check that returned `public explorer url` is publicly accessible (e.g. using incognito browser mode)
* [ ] If `cast-on-tenderly` command is executed several times for the same spell, delete all testnets of the same name except the last one
* [ ] Archive Spell via `make archive-spell` for current date or `date="YYYY-MM-DD" make archive-spell` (date as per target exec date)
* [ ] Commit & Push for Review
* [ ] Wait for CI to PASS
* [ ] Post a comment containing links to the deployed spell and Tenderly Testnet
* [ ] Wait for at Least two Approvals to Share for Publishing to Governance Facilitators
* [ ] Share Deployed Address in [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) discord channel
* [ ] Make sure to tag responsible governance facilitator in the message with the address
Expand Down
7 changes: 7 additions & 0 deletions spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,13 @@ _Insert your local test logs here_
* [ ] Check again that the PR did not modify the `DssExecLib.address` file (e.g. look under the 'Files Changed' PR tab, etc.)
* [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest)
* [ ] (For your tests to be accurate) git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib/releases/latest) latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
* Tenderly Testnet checks
* [ ] A testnet with the name matching spell description is found at [maker dashboard](https://dashboard.tenderly.co/maker/virtual-networks)
* [ ] The testnet name is unique (previous testnets does not have the same name)
* [ ] Cast transaction is set to the correct "receiver" (matches deployed spell address)
* [ ] All actions are executed in the transaction trace
* [ ] No reverts are present that block execution
* [ ] No out-of-gas errors are present
* Archive checks
* [ ] `make diff-archive-spell` for current date or `make diff-archive-spell date="YYYY-MM-DD"`
* [ ] Ensure date corresponds to target Exec Doc date
Expand Down

0 comments on commit 45b65c3

Please sign in to comment.