Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cflags in m4ri.pc #18

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix Cflags in m4ri.pc #18

merged 1 commit into from
Oct 14, 2024

Conversation

sertonix
Copy link
Contributor

Fixes b65eb04

@malb
Copy link
Owner

malb commented Oct 13, 2024

Thanks, I guess we should also rename:

m4ri/m4ri/m4ri_config.h.in

Line 18 in 1ef6f17

#define __M4RI_SIMD_CFLAGS "@SIMD_FLAGS@"
?

@sertonix
Copy link
Contributor Author

sertonix commented Oct 14, 2024 •
edited
Loading

I am uncertain how __M4RI_SIMD_CFLAGS is meant to be used. But if it is for other applications renaming it would just increase maintenance effort without a real benefit. So it doesn't seem to be worth it for me.

@malb malb merged commit 775189b into malb:master Oct 14, 2024
1 check passed
@malb
Copy link
Owner

malb commented Oct 14, 2024

Fair point! Thanks

@sertonix sertonix deleted the patch-1 branch December 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sertonix @malb