-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new War of the Bugs clone from Radar Ltd. #13198
base: master
Are you sure you want to change the base?
Conversation
New working clones ------------------ Rocket Convoy [Luis Arrufat]
src/mame/galaxian/galaxian.cpp
Outdated
|
||
ROM_REGION( 0x0020, "proms", 0 ) | ||
ROM_LOAD( "prom.bin", 0x0000, 0x0020, BAD_DUMP CRC(6a0c7d87) SHA1(140335d85c67c75b65689d4e76d29863c209cf32) ) // Not dumped, borrowed from spactrai | ||
ROM_END | ||
|
||
/* Galaxian hardware mods for War of the Bugs warofbug/warofbugg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the short names in this comment still correct, or have the short names been shuffled while this comment hasn’t been updated? It’s now immediately above the ROM definitions for warofbug
whiles warofbug
and warofbugg
are earlier in the file. The ROM definitions here aren’t in the order of the system definitions, either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, the daughterboard that plugs into Z80 socket is different than the one described on the comment, just the Z80, ROMs and a RAM on this one.
I put this new set right after spactrai, on both ROM definition and the GAME macro... Didn't ordered the other unsorted entries because I really don't know if that comment applies only to 'warofbugu' or also to the other clones after if.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can we work out when the comment got out-of-sync with the code and move it so it’s immediately above the sets it applies to, and refers to the correct short names? This kind of rot is really frustrating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's OK now... At least this section, this driver is huge
Join pins 21 of IC's 1H and 1K together and connect both to +5 volts (although | ||
I've seen one set of docs saying to connect to pin 1 of ic 2N (7408) instead). */ | ||
|
||
ROM_START( warofbug ) // Shows 20c as the base of currency. I know of no US games that used dimes - unless it's another country? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an Australian set – 20c was the standard price for one game in the ’80s.
New working clones
Rocket Convoy [Luis Arrufat]