fix acessibility

manawiki · Nov 28, 2024 · 93d5d90 · 93d5d90
1 parent 36a9f82
commit 93d5d90
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/app/root.tsx b/app/root.tsx
@@ -195,7 +195,7 @@ function App() {
    const [searchToggle, setSearchToggle] = useState(false);
 
    return (
-      <html className={`font-body scroll-smooth ${theme ?? ""}`}>
+      <html lang="en" className={`font-body scroll-smooth ${theme ?? ""}`}>
          <head>
             {!isBot && <ClientHintCheck />}
             <meta charSet="utf-8" />

diff --git a/app/routes/_editor+/blocks+/link/_link.tsx b/app/routes/_editor+/blocks+/link/_link.tsx
@@ -557,7 +557,11 @@ export function LinkBlockElement({ element, children }: Props) {
                                  !element.removeCircleBorder ? 60 : undefined
                               }
                               url={element.icon.url}
-                              alt={element?.name}
+                              alt={
+                                 children
+                                    ? undefined
+                                    : element?.name ?? undefined
+                              }
                            />
                         ) : (
                            <Icon
@@ -605,7 +609,7 @@ export function LinkBlockElement({ element, children }: Props) {
                         width={!element.removeCircleBorder ? 60 : 120}
                         height={!element.removeCircleBorder ? 60 : undefined}
                         url={element.icon.url}
-                        alt={element?.name}
+                        alt={children ? undefined : element?.name ?? undefined}
                      />
                   ) : (
                      <Icon name="component" className="text-1" size={12} />
@@ -646,7 +650,9 @@ export function LinkBlockElement({ element, children }: Props) {
                                  : undefined
                            }
                            url={element.icon.url}
-                           alt={children ? "" : element?.name}
+                           alt={
+                              children ? undefined : element?.name ?? undefined
+                           }
                         />
                      ) : (
                         <Image
@@ -661,7 +667,9 @@ export function LinkBlockElement({ element, children }: Props) {
                               width: element.iconWidth,
                            }}
                            url={element.icon.url}
-                           alt={element?.name}
+                           alt={
+                              children ? undefined : element?.name ?? undefined
+                           }
                         />
                      )}
                      {!element.hideLinkText ? null : (
@@ -696,7 +704,7 @@ export function LinkBlockElement({ element, children }: Props) {
                         element.iconWidth ? element.iconWidth * 2 : undefined
                      }
                      url={element.icon.url}
-                     alt={children ? "" : element?.name}
+                     alt={children ? undefined : element?.name ?? undefined}
                   />
                ) : (
                   <Image
@@ -709,7 +717,7 @@ export function LinkBlockElement({ element, children }: Props) {
                         width: element.iconWidth,
                      }}
                      url={element.icon.url}
-                     alt={element?.name}
+                     alt={children ? undefined : element?.name ?? undefined}
                   />
                )}
                {!element.hideLinkText ? undefined : (