Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Add vb-decompiler-lite.vm #1184

Merged
merged 1 commit into from
Dec 11, 2024
Merged

🤖 Add vb-decompiler-lite.vm #1184

merged 1 commit into from
Dec 11, 2024

Conversation

vm-packages
Copy link
Contributor

Automated PR from #1183 🚀

@vm-packages vm-packages added the 🆕 package New package request/idea/PR label Dec 4, 2024
@sara-rn sara-rn self-requested a review December 5, 2024 08:51
@sara-rn sara-rn force-pushed the package-vb-decompiler-lite branch from fab6cf2 to 6762045 Compare December 5, 2024 11:22
sara-rn
sara-rn reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@sara-rn sara-rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, everything looks good

@sara-rn sara-rn force-pushed the package-vb-decompiler-lite branch from 6762045 to 4c69582 Compare December 5, 2024 11:46
@sara-rn sara-rn self-assigned this Dec 5, 2024
@sara-rn sara-rn requested a review from Ana06 December 5, 2024 11:48
Ana06
Ana06 reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sara-rn please change the name in the uninstallation and squash the commits so that we can get the PR merged 😉

packages/vb-decompiler-lite.vm/tools/chocolateyuninstall.ps1 Outdated Show resolved Hide resolved
packages/vb-decompiler-lite.vm/tools/chocolateyuninstall.ps1 Show resolved Hide resolved
@sara-rn sara-rn force-pushed the package-vb-decompiler-lite branch from 7890069 to bf1c3d3 Compare December 10, 2024 14:34
Ana06
Ana06 reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sara-rn just one more minor thing I had missed in my previous review

packages/vb-decompiler-lite.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@sara-rn sara-rn force-pushed the package-vb-decompiler-lite branch from 6195a26 to 9dd5665 Compare December 11, 2024 15:14
Ana06
Ana06 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally again, installation and uninstallation work well. Thank you for all the work @sara-rn!! 💘

@Ana06 Ana06 merged commit c0a096b into main Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sara-rn sara-rn sara-rn approved these changes

@Ana06 Ana06 Ana06 approved these changes

Assignees

@sara-rn sara-rn

Labels
🆕 package New package request/idea/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vm-packages @Ana06 @sara-rn