-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action to Create Package Wiki #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emtuls where have you tested the action? Can you please provide a link to a run of the action and a wiki example page?
408dae7
to
d2667ca
Compare
I've updated the script as per your suggestion and have the run and wiki example on my fork: Run - https://github.com/emtuls/VM-Packages/actions/runs/12289627139/job/34295427884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing the run and the wiki example page @emtuls!! 🚀
I've made the adjustments you suggested, which can be seen here: |
|
||
- name: Generate Wiki Content | ||
id: generate-content | ||
shell: pwsh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think powershell is the default for windows and this can be deleted. Or am I missing something? 🤔
shell: pwsh |
runs-on: windows-latest | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should you should pin your GitHub Actions by commit-hash: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash (also few lines below)
uses: actions/checkout@v3 | |
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 |
$packagesByCategory = @{} | ||
|
||
foreach ($package in $packages) { | ||
$categoryFile = "$packagesDir/$package/tools/chocolateyinstall.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] there are some indentation inconsistencies here
I think @emtuls does not have time to address the feedback, I'll add a commit to this PR to address it so that we can merge it. |
- Pin `actions/checkout` GitHub Action by commit-hash - Remove unneeded shell tag, as it was set to the default - Explain why `git add .` is needed
This partially resolves #1107 by creating a wiki page that contains a table of tools for each category and is updated daily.
Part 2 will be a second PR.