vm.common: add -iconLocation param to VM-Install-From-Zip #1202
Conversation
fariss
force-pushed
the
add-iconLocation-param
branch
3 times, most recently
from
777a5c4 to
3cc8135
Compare
There was a problem hiding this comment.
Thank for sending a PR to add the iconLocation parameter to VM-Install-From-Zip! 💖
As documented in the wiki:
The version needs to be increased every time you modify an existing package
Otherwise the package can't be pushed to MyGet, GH actions push it when merging the PR. So you need to modify the version in packages/common.vm/common.vm.nuspec to be 0.0.0.20241212. This is also the reason the linter is not happy.
I recommend to also modify the capa-explorer-web.vm package in the same PR that you add the parameter (if you wish in a different commit) as then we can test that the new modification is working. 😉
fariss
force-pushed
the
add-iconLocation-param
branch
from
3cc8135 to
aaaa28b
Compare
fariss
force-pushed
the
add-iconLocation-param
branch
2 times, most recently
from
c927837 to
111a5b4
Compare
fariss
force-pushed
the
add-iconLocation-param
branch
3 times, most recently
from
53e44d3 to
aaa0cab
Compare
| $iconName = "favicon.ico" | ||
| VM-Install-From-Zip $toolName $category $zipUrl $zipSha256 -executableName $executableName -iconLocation $iconName -withoutBinFile -innerFolder $true |
There was a problem hiding this comment.
@Ana06 please let me know if this works out for you.
There was a problem hiding this comment.
Sorry for the late reply (Xmas vacation 🎄 😅). There are two issues:
- You need to request in the nuspec of
capa-explorer-web.vmthat the version ofcommon.vmis the one you where you have added the new function (or newer). To do this, the dependency has to be requested as<dependency id="common.vm" version="0.0.0.20241218" /> - The
iconLocationexpects an absolute path inVM-Install-Shortcut. I think it is good to keep it local here, and look for it inside$toolDirin theVM-Install-From-Zipfunction, to pass the absolute path toVM-Install-Shortcut.
I recommend you to follow the Local Testing instruction in the Wiki to be able to easily test your changes. If you need any issues or questions while setting a local testing setup, please let me know. I am happy to help! 😄
| $iconName = "favicon.ico" | ||
| VM-Install-From-Zip $toolName $category $zipUrl $zipSha256 -executableName $executableName -iconLocation $iconName -withoutBinFile -innerFolder $true |
There was a problem hiding this comment.
Sorry for the late reply (Xmas vacation 🎄 😅). There are two issues:
- You need to request in the nuspec of
capa-explorer-web.vmthat the version ofcommon.vmis the one you where you have added the new function (or newer). To do this, the dependency has to be requested as<dependency id="common.vm" version="0.0.0.20241218" /> - The
iconLocationexpects an absolute path inVM-Install-Shortcut. I think it is good to keep it local here, and look for it inside$toolDirin theVM-Install-From-Zipfunction, to pass the absolute path toVM-Install-Shortcut.
I recommend you to follow the Local Testing instruction in the Wiki to be able to easily test your changes. If you need any issues or questions while setting a local testing setup, please let me know. I am happy to help! 😄
closes #1187