🤖 Add rpcview.vm #705
Merged
🤖 Add rpcview.vm #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm-packages
force-pushed
the
package-rpcview
branch
from
faf4a1a to
18fb229
Compare
binjo
reviewed
Oct 23, 2023
binjo
reviewed
Oct 23, 2023
|
Looks I don't have permission to |
emtuls
previously requested changes
Oct 23, 2023
Ana06
requested changes
Oct 25, 2023
| <description>RpcView is an open-source tool to explore and decompile all RPC functionalities present on a Microsoft system</description> | ||
| <dependencies> | ||
| <dependency id="common.vm" /> | ||
| <dependency id="vcredist140" version="14.36.32532"/> |
There was a problem hiding this comment.
Suggested change
| <dependency id="vcredist140" version="14.36.32532"/> | |
| <dependency id="vcredist140" version="[14.36.32532]" /> |
We should ping the dependency to ensure we test updates or limit it to a lower range like version="[14.36.32532, 14.37)". This dependency is used also in nmap. I think we should create a metapackage to ensure both use the same version and avoid conflicts. I have added this to #673 (we can address it in a different PR).
Ana06
force-pushed
the
package-rpcview
branch
from
d69944d to
be88660
Compare
Ana06
approved these changes
Oct 27, 2023
binjo
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR from #691 🚀