Zero char works now as a marker symbol. The marker-symbol field is al…

…so validated - if it does not match the allowed values it goes back to circle.
mapbox · May 25, 2023 · e15941d · e15941d
1 parent 2be30c2
commit e15941d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/ui/map/clickable_marker.js b/src/ui/map/clickable_marker.js
@@ -10,7 +10,10 @@ class ClickableMarker extends mapboxgl.Marker {
         symbolColor = "#fff"
     } = options
 
-    if (symbol && symbol != "circle") {
+    if (
+      symbol != "circle" && 
+      (makiNames.includes(symbol) || /^[a-z0-9]$/.test(symbol))
+    ) {
       const symbolPath = document.createElement('path');
       this._element.querySelector('circle').replaceWith(symbolPath)
 

diff --git a/src/ui/map/util.js b/src/ui/map/util.js
@@ -126,8 +126,8 @@ const addMarkers = (geojson, context, writable) => {
       }
     }
 
-    let symbol = 'circle'
-    if (d.properties && d.properties['marker-symbol']) {
+    let symbol;
+    if (!(d.properties['marker-symbol'] === undefined)) {
         symbol = d.properties['marker-symbol']
     }