Code changes for application test #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unignore unit test and fix it no need for a var in summary. Make summations more idiomatic eliminating intermediate collections. Use common function in total sum Change var to val Add new tests for getfirstcustomer and make test val names match the type of account they are Remove dangerous list access to use safer operations If we are going to use mutable state it should be as hidden as possible and also a var isn't needed here Make the var a val in account case class, use enum for account types, and add unit tests for account types
…saction make transaction date an argument to facilitate testing Implement MaxiSavings interest feature change Implement MaxiSavings interest feature change DateProvider singleton really isn't needed and remove more vars. Also move accounts out of customer constructor I didn't like the returns mixed into the interest logic Add transfer function. Also add an account balance var to avoid having to sum transactions every time we need that data Removed the balance checks. It's not a requirement and should not be present Add transfer test and verification test of balance matching transaction sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.