fix(core): optional inputs

marcus-sa · Mar 15, 2024 · 466dae3 · 466dae3
1 parent 4801126
commit 466dae3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/core/src/lib/types-builder.ts b/packages/core/src/lib/types-builder.ts
@@ -107,7 +107,7 @@ import {
   getTypeName,
   hasDecorator,
   isAsyncIterable,
-  isParameterNullable,
+  isPropertyOrParameterNullable,
   maybeUnwrapPromiseLikeType,
   maybeUnwrapSubscriptionReturnType,
   requireTypeName,
@@ -726,7 +726,7 @@ export class TypesBuilder {
 
     return argsParameters.reduce((args, parameter) => {
       let type = this.createInputType(parameter.type);
-      if (!isParameterNullable(parameter)) {
+      if (!isPropertyOrParameterNullable(parameter)) {
         type = new GraphQLNonNull(type);
       }
 
@@ -746,7 +746,7 @@ export class TypesBuilder {
     return Object.fromEntries(
       reflectionClass.getProperties().map(property => {
         let type = this.createOutputType(property.type);
-        if (!property.isOptional() && !property.isNullable()) {
+        if (!isPropertyOrParameterNullable(property)) {
           type = new GraphQLNonNull(type);
         }
 

diff --git a/packages/core/src/lib/utils.ts b/packages/core/src/lib/utils.ts
@@ -93,7 +93,7 @@ export function filterReflectionParametersMetaAnnotationsForArguments(
   return argsParameters;
 }
 
-export function isParameterNullable(parameter: ReflectionParameter): boolean {
+export function isPropertyOrParameterNullable(parameter: ReflectionProperty | ReflectionParameter): boolean {
   return parameter.isOptional() || isNullable(parameter.type);
 }