Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds endpoint to list installations, support org_name lookup with more than 30 installations #141

Merged
merged 12 commits into from
Jan 21, 2025

Conversation

ajvpot
Copy link
Contributor

@ajvpot ajvpot commented Jun 17, 2024

This PR adds an endpoint that can be fetched to list the installation IDs. This allows a client of vault to enumerate all installations. Previously, this could only be done by calling the listInstallations API directly with the private key.

  • Add installations endpoint
  • Bugfix: Paginate the installations response from GitHub to support more than 30 installations in org_name lookup as well as the new installations endpoint.

@ajvpot ajvpot closed this Jun 17, 2024
@ajvpot ajvpot changed the title installations endpoint Adds endpoint to list installations Jun 17, 2024
@ajvpot ajvpot reopened this Jun 17, 2024
@ajvpot ajvpot marked this pull request as draft June 17, 2024 20:22
@ajvpot ajvpot marked this pull request as draft June 17, 2024 20:22
@ajvpot ajvpot marked this pull request as draft June 17, 2024 20:22
@ajvpot ajvpot marked this pull request as ready for review July 9, 2024 18:31
@ajvpot ajvpot changed the title Adds endpoint to list installations Adds endpoint to list installations, support org_name lookup with more than 30 installations Jul 9, 2024
@martinbaillie martinbaillie force-pushed the master branch 6 times, most recently from 21253d0 to 1c11fa8 Compare January 18, 2025 10:15
martinbaillie and others added 8 commits January 18, 2025 22:01
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.0 to 4.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.1.0...v4.5.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Martin Baillie <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 5.1.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.5.0...v5.1.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@martinbaillie martinbaillie merged commit 75580a4 into martinbaillie:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants