Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiida-sssp and/or aiida-pseudo to image #35

Open
chrisjsewell opened this issue Jun 11, 2020 · 3 comments
Open

Add aiida-sssp and/or aiida-pseudo to image #35

chrisjsewell opened this issue Jun 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

As discussed in #34

@sphuber
Copy link
Contributor

sphuber commented Jun 18, 2020

Definitely wouldn't do both. If there is no rush, I would wait for aiida-pseudo to be published. It currently is working, see master branch: https://github.com/aiidateam/aiida-pseudo/commits/master
But I haven't released it yet, because I haven't had the time to discuss with other developers about the design/naming choices etc. Also some advanced functionality that was in aiida-sssp, i.e. to automatically get the cutoffs for a given structure, have not yet been ported.

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Jun 18, 2020

Thanks @sphuber, so just to clarify aiida-pseudo will eventually subsume aiida-sssp?

@sphuber
Copy link
Contributor

sphuber commented Jun 18, 2020

yes, aiida-sssp=0.1.1 works for now, but only supports installing from Materials Cloud. The aiida-pseudo package will generalize the functionality to support generic pseudo families, not just SSSP and even not just UPF, and will allow to install from pseudos on local file system. They are incompatible in the sense that the entry points for the Group subclases are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants