Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename all likedUsers to likedUser & add error handling #138

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented Sep 22, 2024

Issue Number

Description

구현 내용 및 작업한 내용

  • likedUsers는 전부 likedUser로 변경!
  • /intro 진입 시 GET /users/me나 GET /maps에서 에러가 발생한다면, 에러 토스트 띄우고 로그인 화면 띄우기 (닉네임 입력 또는 지도 이름 입력 화면 안 나오게 하기)

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅠㅠ 고생쓰

Copy link

The latest updates on your projects. Preview: https://vitamin-c-2ufexys05-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-22T11:42:51Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-csq5ygyo7-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-22T11:48:36Z

@hee-suh hee-suh changed the title fix: rename all likedUsers to likedUser fix: rename all likedUsers to likedUser & add error handling Sep 22, 2024
@hee-suh hee-suh merged commit 32b5068 into main Sep 22, 2024
3 checks passed
@hee-suh hee-suh deleted the fix/hotfix branch September 22, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants