Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add map description and refactor my map info page #141

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented Sep 23, 2024

Issue Number

Description

구현 내용 및 작업한 내용

  • 처음에는 지도 제목만 포함했던 컴포넌트가 점점 커지고 있어서 리팩토링을 했어요
  • 지도 한 줄 소개를 추가했어요
  • Textarea 컴포넌트 구현
    • multiline 지원
    • 글자수 표시
    • maxLength를 넘어서도 입력은 허용
2024-09-26.2.26.21.mov

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • Input 컴포넌트랑 지도 정보 수정에 필요한 입력란의 요구사항이 꽤 달라서 Textarea 컴포넌트로 뺐습니당

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-9krlpr1u8-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-23T10:26:20Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-85458ev84-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-25T17:06:09Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-blmg0un15-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-25T17:19:04Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-myyt17nel-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-25T17:25:14Z

@hee-suh hee-suh merged commit a12c0f2 into main Sep 26, 2024
3 checks passed
@hee-suh hee-suh deleted the feature/map-description branch September 26, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants